From e7f58da49196f1cddcc3ffbe043605f6617f041d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Benjamin=20Cab=C3=A9?= Date: Thu, 12 Jun 2025 21:55:09 +0200 Subject: [PATCH] drivers: adc: use asserts in adc_gain_invert implementations MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit no need for runtime checks here, let's save a few bytes of code Signed-off-by: Benjamin Cabé --- drivers/adc/adc_common.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/adc/adc_common.c b/drivers/adc/adc_common.c index 8b8f9c4802a..853a55bbc06 100644 --- a/drivers/adc/adc_common.c +++ b/drivers/adc/adc_common.c @@ -5,6 +5,7 @@ */ #include +#include struct gain_desc { uint8_t mul; @@ -41,10 +42,10 @@ int adc_gain_invert(enum adc_gain gain, int32_t *value) if ((uint8_t)gain < ARRAY_SIZE(gains)) { const struct gain_desc *gdp = &gains[gain]; - if ((gdp->mul != 0) && (gdp->div != 0)) { - *value = (gdp->mul * *value) / gdp->div; - rv = 0; - } + __ASSERT_NO_MSG(gdp->mul != 0); + __ASSERT_NO_MSG(gdp->div != 0); + *value = (gdp->mul * *value) / gdp->div; + rv = 0; } return rv; @@ -57,10 +58,10 @@ int adc_gain_invert_64(enum adc_gain gain, int64_t *value) if ((uint8_t)gain < ARRAY_SIZE(gains)) { const struct gain_desc *gdp = &gains[gain]; - if ((gdp->mul != 0) && (gdp->div != 0)) { - *value = (gdp->mul * *value) / gdp->div; - rv = 0; - } + __ASSERT_NO_MSG(gdp->mul != 0); + __ASSERT_NO_MSG(gdp->div != 0); + *value = (gdp->mul * *value) / gdp->div; + rv = 0; } return rv;