michaelh/zephyr
1
0
Fork 0
Code Releases Activity

power_domain: gpio: improve logging

Browse source 
Improve the power domain logging by making the log level configurable
and boosting the log level of the messages printed when the domain turns
on and off.

Signed-off-by: Jordan Yates <jordan.yates@data61.csiro.au>
This commit is contained in:
Jordan Yates 2022-05-09 14:12:27 +10:00 • committed by Anas Nashif
commit e5c391fad6
2 changed files with 7 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
drivers/power_domain/Kconfig
View file

@ -8,6 +8,10 @@ menuconfig POWER_DOMAIN
if POWER_DOMAIN if POWER_DOMAIN
module = POWER_DOMAIN
module-str = power_domain
source "subsys/logging/Kconfig.template.log_config"
config POWER_DOMAIN_GPIO config POWER_DOMAIN_GPIO
bool "GPIO controlled power domain" bool "GPIO controlled power domain"
depends on GPIO depends on GPIO

6
drivers/power_domain/power_domain_gpio.c
View file

@ -13,7 +13,7 @@
#include <zephyr/pm/device_runtime.h> #include <zephyr/pm/device_runtime.h>
#include <zephyr/logging/log.h> #include <zephyr/logging/log.h>
LOG_MODULE_REGISTER(power_domain_gpio, LOG_LEVEL_INF); LOG_MODULE_REGISTER(power_domain_gpio, CONFIG_POWER_DOMAIN_LOG_LEVEL);
struct pd_gpio_config { struct pd_gpio_config {
struct gpio_dt_spec enable; struct gpio_dt_spec enable;
@ -45,7 +45,7 @@ static int pd_gpio_pm_action(const struct device *dev,
k_sleep(data->next_boot); k_sleep(data->next_boot);
/* Switch power on */ /* Switch power on */
gpio_pin_set_dt(&cfg->enable, 1); gpio_pin_set_dt(&cfg->enable, 1);
LOG_DBG("%s is now ON", dev->name); LOG_INF("%s is now ON", dev->name);
/* Wait for domain to come up */ /* Wait for domain to come up */
k_sleep(K_USEC(cfg->startup_delay_us)); k_sleep(K_USEC(cfg->startup_delay_us));
/* Notify supported devices they are now powered */ /* Notify supported devices they are now powered */
@ -56,7 +56,7 @@ static int pd_gpio_pm_action(const struct device *dev,
pm_device_children_action_run(dev, PM_DEVICE_ACTION_TURN_OFF, NULL); pm_device_children_action_run(dev, PM_DEVICE_ACTION_TURN_OFF, NULL);
/* Switch power off */ /* Switch power off */
gpio_pin_set_dt(&cfg->enable, 0); gpio_pin_set_dt(&cfg->enable, 0);
LOG_DBG("%s is now OFF and powered", dev->name); LOG_INF("%s is now OFF", dev->name);
/* Store next time we can boot */ /* Store next time we can boot */
next_boot_ticks = k_uptime_ticks() + k_us_to_ticks_ceil32(cfg->off_on_delay_us); next_boot_ticks = k_uptime_ticks() + k_us_to_ticks_ceil32(cfg->off_on_delay_us);
data->next_boot = K_TIMEOUT_ABS_TICKS(next_boot_ticks); data->next_boot = K_TIMEOUT_ABS_TICKS(next_boot_ticks);