michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: pwm_mcux_sctimer: Use clock control API

Browse source 
Use zephyr clock control api instead of hal functions
directly in the sctimer driver

Signed-off-by: Declan Snyder <declan.snyder@nxp.com>
This commit is contained in:
Declan Snyder 2023-09-07 10:36:57 -05:00 • committed by Carles Cufí
commit e48714949e
2 changed files with 19 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

2
drivers/pwm/Kconfig.mcux_sctimer
View file

@ -5,6 +5,6 @@ config PWM_MCUX_SCTIMER
bool "MCUX SCTimer PWM driver" bool "MCUX SCTimer PWM driver"
default y default y
depends on DT_HAS_NXP_SCTIMER_PWM_ENABLED depends on DT_HAS_NXP_SCTIMER_PWM_ENABLED
select PINCTRL depends on CLOCK_CONTROL && PINCTRL
help help
Enable sctimer based pwm driver. Enable sctimer based pwm driver.

25
drivers/pwm/pwm_mcux_sctimer.c
View file

@ -12,6 +12,7 @@
#include <fsl_sctimer.h> #include <fsl_sctimer.h>
#include <fsl_clock.h> #include <fsl_clock.h>
#include <zephyr/drivers/pinctrl.h> #include <zephyr/drivers/pinctrl.h>
#include <zephyr/drivers/clock_control.h>
#include <zephyr/logging/log.h> #include <zephyr/logging/log.h>
@ -23,6 +24,8 @@ struct pwm_mcux_sctimer_config {
SCT_Type *base; SCT_Type *base;
uint32_t prescale; uint32_t prescale;
const struct pinctrl_dev_config *pincfg; const struct pinctrl_dev_config *pincfg;
const struct device *clock_dev;
clock_control_subsys_t clock_subsys;
}; };
struct pwm_mcux_sctimer_data { struct pwm_mcux_sctimer_data {
@ -79,11 +82,11 @@ static int mcux_sctimer_pwm_set_cycles(const struct device *dev,
data->period_cycles[channel] = period_cycles; data->period_cycles[channel] = period_cycles;
/* if (clock_control_get_rate(config->clock_dev, config->clock_subsys,
* Do not divide by the prescale factor as this is accounted for in &clock_freq)) {
* the SDK function return -EINVAL;
*/ }
clock_freq = CLOCK_GetFreq(kCLOCK_BusClk);
pwm_freq = (clock_freq / config->prescale) / period_cycles; pwm_freq = (clock_freq / config->prescale) / period_cycles;
if (pwm_freq == 0) { if (pwm_freq == 0) {
@ -117,8 +120,14 @@ static int mcux_sctimer_pwm_get_cycles_per_sec(const struct device *dev,
uint64_t *cycles) uint64_t *cycles)
{ {
const struct pwm_mcux_sctimer_config *config = dev->config; const struct pwm_mcux_sctimer_config *config = dev->config;
uint32_t clock_freq;
*cycles = CLOCK_GetFreq(kCLOCK_BusClk) / config->prescale; if (clock_control_get_rate(config->clock_dev, config->clock_subsys,
&clock_freq)) {
return -EINVAL;
}
*cycles = clock_freq / config->prescale;
return 0; return 0;
} }
@ -138,7 +147,7 @@ static int mcux_sctimer_pwm_init(const struct device *dev)
} }
SCTIMER_GetDefaultConfig(&pwm_config); SCTIMER_GetDefaultConfig(&pwm_config);
/* Divide the SCT clock by 8 */
pwm_config.prescale_l = config->prescale - 1; pwm_config.prescale_l = config->prescale - 1;
status = SCTIMER_Init(config->base, &pwm_config); status = SCTIMER_Init(config->base, &pwm_config);
@ -170,6 +179,8 @@ static const struct pwm_driver_api pwm_mcux_sctimer_driver_api = {
.base = (SCT_Type *)DT_INST_REG_ADDR(n), \ .base = (SCT_Type *)DT_INST_REG_ADDR(n), \
.prescale = DT_INST_PROP(n, prescaler), \ .prescale = DT_INST_PROP(n, prescaler), \
.pincfg = PINCTRL_DT_INST_DEV_CONFIG_GET(n), \ .pincfg = PINCTRL_DT_INST_DEV_CONFIG_GET(n), \
.clock_dev = DEVICE_DT_GET(DT_INST_CLOCKS_CTLR(n)), \
.clock_subsys = (clock_control_subsys_t)DT_INST_CLOCKS_CELL(n, name),\
}; \ }; \
\ \
DEVICE_DT_INST_DEFINE(n, \ DEVICE_DT_INST_DEFINE(n, \