michaelh/zephyr
1
0
Fork 0
Code Releases Activity

ethernet: eth_liteeth: Avoid bitwise operations

Browse source 
With universal LiteX HAL working, there is no need to perform multibyte
reads and writes using bitwise operations.
Just use appropriate `litex_read*` or `litex_write*` function.

Signed-off-by: Michal Sieron <msieron@internships.antmicro.com>
This commit is contained in:
Michal Sieron 2022-04-08 14:52:58 +02:00 • committed by Carles Cufí
commit e3db9a49c8
1 changed files with 2 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

8
drivers/ethernet/eth_liteeth.c
View file

@ -94,8 +94,7 @@ static int eth_tx(const struct device *dev, struct net_pkt *pkt)
net_pkt_read(pkt, context->tx_buf[context->txslot], len);
litex_write8(context->txslot, LITEETH_TX_SLOT);
litex_write8(len >> 8, LITEETH_TX_LENGTH);
litex_write8(len & 0xFF, LITEETH_TX_LENGTH + 4);
litex_write16(len, LITEETH_TX_LENGTH);
/* wait for the device to be ready to transmit */
while (litex_read8(LITEETH_TX_READY) == 0) {
@ -132,10 +131,7 @@ static void eth_rx(const struct device *port)
key = irq_lock();
/* get frame's length */
for (int i = 0; i < 4; i++) {
len <<= 8;
len |= litex_read8(LITEETH_RX_LENGTH + i * 0x4);
}
len = litex_read32(LITEETH_RX_LENGTH);
/* which slot is the frame in */
context->rxslot = litex_read8(LITEETH_RX_SLOT);