michaelh/zephyr
1
0
Fork 0
Code Releases Activity

stack_sentinel: hang system on failure

Browse source 
Stack sentinel doesn't prevent corruption, it just notices when
it happens. Any memory could be in a bad state and it's more
appropriate to take the entire system down rather than just kill
the thread.

Fatal testcase will still work since it installs its own
_SysFatalErrorHandler.

Signed-off-by: Andrew Boie <andrew.p.boie@intel.com>
This commit is contained in:
Andrew Boie 2017-06-07 15:15:19 -07:00 • committed by Maureen Helm
commit e3550a29ff
5 changed files with 25 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

5
arch/arm/core/sys_fatal_error_handler.c
View file

@ -44,6 +44,11 @@ void __weak _SysFatalErrorHandler(unsigned int reason,
ARG_UNUSED(pEsf); ARG_UNUSED(pEsf);
#if !defined(CONFIG_SIMPLE_FATAL_ERROR_HANDLER) #if !defined(CONFIG_SIMPLE_FATAL_ERROR_HANDLER)
#ifdef CONFIG_STACK_SENTINEL
if (reason == _NANO_ERR_STACK_CHK_FAIL) {
goto hang_system;
}
#endif
if (reason == _NANO_ERR_KERNEL_PANIC) { if (reason == _NANO_ERR_KERNEL_PANIC) {
goto hang_system; goto hang_system;
} }

5
arch/nios2/core/fatal.c
View file

@ -226,6 +226,11 @@ FUNC_NORETURN __weak void _SysFatalErrorHandler(unsigned int reason,
ARG_UNUSED(pEsf); ARG_UNUSED(pEsf);
#if !defined(CONFIG_SIMPLE_FATAL_ERROR_HANDLER) #if !defined(CONFIG_SIMPLE_FATAL_ERROR_HANDLER)
#ifdef CONFIG_STACK_SENTINEL
if (reason == _NANO_ERR_STACK_CHK_FAIL) {
goto hang_system;
}
#endif
if (reason == _NANO_ERR_KERNEL_PANIC) { if (reason == _NANO_ERR_KERNEL_PANIC) {
goto hang_system; goto hang_system;
} }

5
arch/riscv32/core/fatal.c
View file

@ -140,6 +140,11 @@ FUNC_NORETURN __weak void _SysFatalErrorHandler(unsigned int reason,
ARG_UNUSED(esf); ARG_UNUSED(esf);
#if !defined(CONFIG_SIMPLE_FATAL_ERROR_HANDLER) #if !defined(CONFIG_SIMPLE_FATAL_ERROR_HANDLER)
#ifdef CONFIG_STACK_SENTINEL
if (reason == _NANO_ERR_STACK_CHK_FAIL) {
goto hang_system;
}
#endif
if (reason == _NANO_ERR_KERNEL_PANIC) { if (reason == _NANO_ERR_KERNEL_PANIC) {
goto hang_system; goto hang_system;
} }

5
arch/x86/core/sys_fatal_error_handler.c
View file

@ -44,6 +44,11 @@ FUNC_NORETURN __weak void _SysFatalErrorHandler(unsigned int reason,
ARG_UNUSED(pEsf); ARG_UNUSED(pEsf);
#if !defined(CONFIG_SIMPLE_FATAL_ERROR_HANDLER) #if !defined(CONFIG_SIMPLE_FATAL_ERROR_HANDLER)
#ifdef CONFIG_STACK_SENTINEL
if (reason == _NANO_ERR_STACK_CHK_FAIL) {
goto hang_system;
}
#endif
if (reason == _NANO_ERR_KERNEL_PANIC) { if (reason == _NANO_ERR_KERNEL_PANIC) {
goto hang_system; goto hang_system;
} }

5
arch/xtensa/core/fatal.c
View file

@ -241,6 +241,11 @@ FUNC_NORETURN __weak void _SysFatalErrorHandler(unsigned int reason,
ARG_UNUSED(pEsf); ARG_UNUSED(pEsf);
#if !defined(CONFIG_SIMPLE_FATAL_ERROR_HANDLER) #if !defined(CONFIG_SIMPLE_FATAL_ERROR_HANDLER)
#ifdef CONFIG_STACK_SENTINEL
if (reason == _NANO_ERR_STACK_CHK_FAIL) {
goto hang_system;
}
#endif
if (reason == _NANO_ERR_KERNEL_PANIC) { if (reason == _NANO_ERR_KERNEL_PANIC) {
goto hang_system; goto hang_system;
} }