michaelh/zephyr
1
0
Fork 0
Code Releases Activity

Shell: Make full_line_cmd return false on empty lines

Browse source 
The fact that the function was returning `true` for empty line was an
unexpected behavior according to the name of the function itself and how
it was used elsewhere.

Signed-off-by: Théo Battrel <theo.battrel@nordicsemi.no>
This commit is contained in:
Théo Battrel 2024-08-21 15:11:35 +02:00 • committed by Anas Nashif
commit e34542a3de
1 changed files with 7 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

9
subsys/shell/shell_ops.c
View file

@ -43,8 +43,13 @@ void z_shell_op_cursor_horiz_move(const struct shell *sh, int32_t delta)
*/
static inline bool full_line_cmd(const struct shell *sh)
{
return ((sh->ctx->cmd_buff_len + z_shell_strlen(sh->ctx->prompt))
% sh->ctx->vt100_ctx.cons.terminal_wid == 0U);
size_t line_length = sh->ctx->cmd_buff_len + z_shell_strlen(sh->ctx->prompt);
if (line_length == 0) {
return false;
}
return (line_length % sh->ctx->vt100_ctx.cons.terminal_wid == 0U);
}
/* Function returns true if cursor is at beginning of an empty line. */