michaelh/zephyr
1
0
Fork 0
Code Releases Activity

posix: signals: deprecate CONFIG_POSIX_LIMITS_RTSIG_MAX

Browse source 
There were two Kconfig constants defined for (effectively) the
same thing in Zephyr. Namely, RTSIG_MAX - the highest valued
real-time signal.

Deprecate CONFIG_POSIX_LIMITS_RTSIG_MAX in favour of
CONFIG_POSIX_RTSIG_MAX since the latter more closely matches
convention.

Signed-off-by: Chris Friedt <cfriedt@tenstorrent.com>
This commit is contained in:
Chris Friedt 2024-05-20 21:51:50 -04:00 • committed by David Leach
commit e2fc78af23
4 changed files with 22 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

1
doc/services/portability/posix/kconfig/index.rst
View file

@ -27,7 +27,6 @@ implementation of the POSIX API.
* :kconfig:option:`CONFIG_POSIX_API` * :kconfig:option:`CONFIG_POSIX_API`
* :kconfig:option:`CONFIG_POSIX_CLOCK` * :kconfig:option:`CONFIG_POSIX_CLOCK`
* :kconfig:option:`CONFIG_POSIX_FS` * :kconfig:option:`CONFIG_POSIX_FS`
* :kconfig:option:`CONFIG_POSIX_LIMITS_RTSIG_MAX`
* :kconfig:option:`CONFIG_POSIX_MAX_FDS` * :kconfig:option:`CONFIG_POSIX_MAX_FDS`
* :kconfig:option:`CONFIG_POSIX_MAX_OPEN_FILES` * :kconfig:option:`CONFIG_POSIX_MAX_OPEN_FILES`
* :kconfig:option:`CONFIG_POSIX_MQUEUE` * :kconfig:option:`CONFIG_POSIX_MQUEUE`

10
lib/posix/options/Kconfig.deprecated
View file

@ -5,4 +5,14 @@
# This file should be removed after Zephyr 4.0 is released # This file should be removed after Zephyr 4.0 is released
menu "Deprecated POSIX options" menu "Deprecated POSIX options"
config POSIX_LIMITS_RTSIG_MAX
int "_POSIX_RTSIG_MAX value in limits.h [DEPRECATED]"
default POSIX_RTSIG_MAX if POSIX_REALTIME_SIGNALS
default 0
help
This option is deprecated.
Please use CONFIG_POSIX_RTSIG_MAX instead.
endmenu endmenu

21
lib/posix/options/Kconfig.signal
View file

@ -4,15 +4,23 @@
menu "Signal support" menu "Signal support"
# needed outside of if clause above to define constants & types in signal.h config POSIX_REALTIME_SIGNALS
bool "POSIX realtime signals"
default y if POSIX_API
help
Enable support for POSIX realtime signals.
if POSIX_REALTIME_SIGNALS
config POSIX_RTSIG_MAX config POSIX_RTSIG_MAX
int "Maximum number of realtime signals" int "Maximum number of realtime signals"
default 31 if POSIX_SIGNAL default 8
default 0
help help
Define the maximum number of realtime signals (RTSIG_MAX). Define the maximum number of realtime signals (RTSIG_MAX).
The range of realtime signals is [SIGRTMIN .. (SIGRTMIN+RTSIG_MAX)] The range of realtime signals is [SIGRTMIN .. (SIGRTMIN+RTSIG_MAX)]
endif # POSIX_REALTIME_SIGNALS
config POSIX_SIGNAL config POSIX_SIGNAL
bool "Support for POSIX signal APIs" bool "Support for POSIX signal APIs"
default y if POSIX_API default y if POSIX_API
@ -28,13 +36,6 @@ config POSIX_SIGNAL_STRING_DESC
Use full description for the strsignal API. Use full description for the strsignal API.
Will use 256 bytes of ROM. Will use 256 bytes of ROM.
config POSIX_LIMITS_RTSIG_MAX
int "_POSIX_RTSIG_MAX value in limits.h"
default 8
help
Define the _POSIX_RTSIG_MAX value in limits.h.
IEEE 1003.1 defines this to be 8.
endif endif
endmenu # "Signal support" endmenu # "Signal support"

3
lib/posix/options/signal.c
View file

@ -13,8 +13,7 @@
#define SIGNO_WORD_IDX(_signo) (signo / BITS_PER_LONG) #define SIGNO_WORD_IDX(_signo) (signo / BITS_PER_LONG)
#define SIGNO_WORD_BIT(_signo) (signo & BIT_MASK(LOG2(BITS_PER_LONG))) #define SIGNO_WORD_BIT(_signo) (signo & BIT_MASK(LOG2(BITS_PER_LONG)))
BUILD_ASSERT(CONFIG_POSIX_LIMITS_RTSIG_MAX >= 0); BUILD_ASSERT(CONFIG_POSIX_RTSIG_MAX >= 0);
BUILD_ASSERT(CONFIG_POSIX_RTSIG_MAX >= CONFIG_POSIX_LIMITS_RTSIG_MAX);
static inline bool signo_valid(int signo) static inline bool signo_valid(int signo)
{ {