michaelh/zephyr
1
0
Fork 0
Code Releases Activity

soc: microchip: mec172x: Add CPU barriers during low power entry/exit

Browse source 
Follow ARM architecture recommendations:
* Use Data Synchronization Barrier (DSB) instruction before WFI,
to ensure that pending memory transactions complete before
changing state.

* To guarantee pend interrupts are recognized before subsequent
operation, use ISB after CPSIE (__irq_enable)

This prevents sporadicy delayed ISRs due to continous MEC172x
entering/exiting deep sleep.

Signed-off-by: Jose Alberto Meza <jose.a.meza.arellano@intel.com>
This commit is contained in:
Jose Alberto Meza 2024-08-20 18:23:54 -07:00 • committed by Anas Nashif
commit e2b34b96e3
1 changed files with 3 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

7
soc/microchip/mec/mec172x/power.c
View file

@ -51,13 +51,11 @@ static void z_power_soc_deep_sleep(void)
{ {
struct pcr_regs *pcr = PCR_XEC_REG_BASE; struct pcr_regs *pcr = PCR_XEC_REG_BASE;
struct htmr_regs *htmr0 = HTMR_0_XEC_REG_BASE; struct htmr_regs *htmr0 = HTMR_0_XEC_REG_BASE;
uint32_t basepri = 0U;
uint32_t temp = 0U; uint32_t temp = 0U;
PM_DP_ENTER(); PM_DP_ENTER();
__disable_irq(); __disable_irq();
basepri = __get_BASEPRI();
soc_deep_sleep_periph_save(); soc_deep_sleep_periph_save();
soc_deep_sleep_wake_en(); soc_deep_sleep_wake_en();
@ -78,6 +76,7 @@ static void z_power_soc_deep_sleep(void)
soc_debug_sleep_clk_req(); soc_debug_sleep_clk_req();
#endif #endif
__set_BASEPRI(0); __set_BASEPRI(0);
__DSB();
__WFI(); /* triggers sleep hardware */ __WFI(); /* triggers sleep hardware */
__NOP(); __NOP();
__NOP(); __NOP();
@ -103,8 +102,6 @@ static void z_power_soc_deep_sleep(void)
htmr0->PRLD = 0U; /* stop */ htmr0->PRLD = 0U; /* stop */
__set_BASEPRI(basepri);
soc_deep_sleep_non_wake_dis(); soc_deep_sleep_non_wake_dis();
soc_deep_sleep_wake_dis(); soc_deep_sleep_wake_dis();
soc_deep_sleep_periph_restore(); soc_deep_sleep_periph_restore();
@ -133,6 +130,7 @@ static void z_power_soc_sleep(void)
pcr->SYS_SLP_CTRL = MCHP_PCR_SYS_SLP_LIGHT; pcr->SYS_SLP_CTRL = MCHP_PCR_SYS_SLP_LIGHT;
pcr->OSC_ID = pcr->SYS_SLP_CTRL; pcr->OSC_ID = pcr->SYS_SLP_CTRL;
__set_BASEPRI(0); __set_BASEPRI(0);
__DSB();
__WFI(); /* triggers sleep hardware */ __WFI(); /* triggers sleep hardware */
__NOP(); __NOP();
__NOP(); __NOP();
@ -171,5 +169,6 @@ void pm_state_set(enum pm_state state, uint8_t substate_id)
void pm_state_exit_post_ops(enum pm_state state, uint8_t substate_id) void pm_state_exit_post_ops(enum pm_state state, uint8_t substate_id)
{ {
__enable_irq(); __enable_irq();
__ISB();
irq_unlock(0); irq_unlock(0);
} }