michaelh/zephyr
1
0
Fork 0
Code Releases Activity

pm: require pm_state_set/pm_exit_post_ops

Browse source 
Any system supporting PM must now implement
pm_state_set/pm_exit_post_ops. Before this change any platform could
enable CONFIG_PM=y, even though it did nothing, ie, no power savings at
all.

Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
This commit is contained in:
Gerard Marull-Paretas 2023-07-17 16:59:26 +02:00 • committed by Fabio Baltieri
commit e1eedd1a9f
1 changed files with 2 additions and 31 deletions
Download patch file Download diff file Expand all files Collapse all files

33
subsys/pm/pm.c
View file

@ -107,35 +107,6 @@ static void pm_resume_devices(void)
#endif /* !CONFIG_PM_DEVICE_RUNTIME_EXCLUSIVE */ #endif /* !CONFIG_PM_DEVICE_RUNTIME_EXCLUSIVE */
#endif /* CONFIG_PM_DEVICE */ #endif /* CONFIG_PM_DEVICE */
static inline void pm_exit_pos_ops(struct pm_state_info *info)
{
extern __weak void
pm_state_exit_post_ops(enum pm_state state, uint8_t substate_id);
if (pm_state_exit_post_ops != NULL) {
pm_state_exit_post_ops(info->state, info->substate_id);
} else {
/*
* This function is supposed to be overridden to do SoC or
* architecture specific post ops after sleep state exits.
*
* The kernel expects that irqs are unlocked after this.
*/
irq_unlock(0);
}
}
static inline void state_set(struct pm_state_info *info)
{
extern __weak void
pm_state_set(enum pm_state state, uint8_t substate_id);
if (pm_state_set != NULL) {
pm_state_set(info->state, info->substate_id);
}
}
/* /*
* Function called to notify when the system is entering / exiting a * Function called to notify when the system is entering / exiting a
* power state * power state
@ -178,7 +149,7 @@ void pm_system_resume(void)
* and it may schedule another thread. * and it may schedule another thread.
*/ */
if (atomic_test_and_clear_bit(z_post_ops_required, id)) { if (atomic_test_and_clear_bit(z_post_ops_required, id)) {
pm_exit_pos_ops(&z_cpus_pm_state[id]); pm_state_exit_post_ops(z_cpus_pm_state[id].state, z_cpus_pm_state[id].substate_id);
pm_state_notify(false); pm_state_notify(false);
z_cpus_pm_state[id] = (struct pm_state_info){PM_STATE_ACTIVE, z_cpus_pm_state[id] = (struct pm_state_info){PM_STATE_ACTIVE,
0, 0}; 0, 0};
@ -266,7 +237,7 @@ bool pm_system_suspend(int32_t ticks)
/* Enter power state */ /* Enter power state */
pm_state_notify(true); pm_state_notify(true);
atomic_set_bit(z_post_ops_required, id); atomic_set_bit(z_post_ops_required, id);
state_set(&z_cpus_pm_state[id]); pm_state_set(z_cpus_pm_state[id].state, z_cpus_pm_state[id].substate_id);
pm_stats_stop(); pm_stats_stop();
/* Wake up sequence starts here */ /* Wake up sequence starts here */