From e17d5ed2824c697de2c99e281e91f0bdda47cc18 Mon Sep 17 00:00:00 2001 From: Shawn Nematbakhsh Date: Mon, 16 May 2022 11:21:42 -0700 Subject: [PATCH] drivers: spi_sifive: Use uint8_t data/buffer types to match spi_context. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit spi_context uses uint8_t buffers, and HW rxdata / txdata registers only contain 8 bits of data (along with b31 full / empty flag), so uint8_t is appropriate. Suggested-by: Andrzej Głąbek Signed-off-by: Shawn Nematbakhsh --- drivers/spi/spi_sifive.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/spi/spi_sifive.c b/drivers/spi/spi_sifive.c index 0fdb3eb489f..8440a9a0100 100644 --- a/drivers/spi/spi_sifive.c +++ b/drivers/spi/spi_sifive.c @@ -100,7 +100,7 @@ int spi_config(const struct device *dev, uint32_t frequency, return 0; } -void spi_sifive_send(const struct device *dev, uint16_t frame) +void spi_sifive_send(const struct device *dev, uint8_t frame) { while (sys_read32(SPI_REG(dev, REG_TXDATA)) & SF_TXDATA_FULL) { } @@ -108,20 +108,20 @@ void spi_sifive_send(const struct device *dev, uint16_t frame) sys_write32((uint32_t) frame, SPI_REG(dev, REG_TXDATA)); } -uint16_t spi_sifive_recv(const struct device *dev) +uint8_t spi_sifive_recv(const struct device *dev) { uint32_t val; while ((val = sys_read32(SPI_REG(dev, REG_RXDATA))) & SF_RXDATA_EMPTY) { } - return (uint16_t) val; + return (uint8_t) val; } void spi_sifive_xfer(const struct device *dev, const bool hw_cs_control) { struct spi_context *ctx = &SPI_DATA(dev)->ctx; - uint16_t txd, rxd; + uint8_t txd, rxd; do { /* Send a frame */