michaelh/zephyr
1
0
Fork 0
Code Releases Activity

samples: counter: Add err check on set_alarm call

Browse source 
Error checking was missing following call to
counter_set_channel_alarm.
This was reported in coverity report 203523.

Fixes #18374

Additionally remove unneeded err initialization in main function

Signed-off-by: Erwan Gouriou <erwan.gouriou@linaro.org>
This commit is contained in:
Erwan Gouriou 2019-08-28 10:33:06 +02:00 • committed by Kumar Gala
commit e15852cd62
1 changed files with 8 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

10
samples/drivers/counter/alarm/src/main.c
View file

@ -23,6 +23,7 @@ static void test_counter_interrupt_fn(struct device *counter_dev,
u64_t now_usec = counter_ticks_to_us(counter_dev, now_ticks); u64_t now_usec = counter_ticks_to_us(counter_dev, now_ticks);
int now_sec = (int)(now_usec / USEC_PER_SEC); int now_sec = (int)(now_usec / USEC_PER_SEC);
struct counter_alarm_cfg *config = user_data; struct counter_alarm_cfg *config = user_data;
int err;
printk("!!! Alarm !!!\n"); printk("!!! Alarm !!!\n");
printk("Now: %u\n", now_sec); printk("Now: %u\n", now_sec);
@ -34,13 +35,18 @@ static void test_counter_interrupt_fn(struct device *counter_dev,
(u32_t)(counter_ticks_to_us(counter_dev, (u32_t)(counter_ticks_to_us(counter_dev,
config->ticks) / USEC_PER_SEC), config->ticks) / USEC_PER_SEC),
config->ticks); config->ticks);
counter_set_channel_alarm(counter_dev, ALARM_CHANNEL_ID, user_data);
err = counter_set_channel_alarm(counter_dev, ALARM_CHANNEL_ID,
user_data);
if (err != 0) {
printk("Alarm could not be set\n");
}
} }
void main(void) void main(void)
{ {
struct device *counter_dev; struct device *counter_dev;
int err = 0; int err;
printk("Counter alarm sample\n\n"); printk("Counter alarm sample\n\n");
counter_dev = device_get_binding(DT_RTC_0_NAME); counter_dev = device_get_binding(DT_RTC_0_NAME);