From e1290bedeb19d8152f133587bb70e56de4140b70 Mon Sep 17 00:00:00 2001 From: Henrik Brix Andersen Date: Thu, 31 Mar 2022 19:21:19 +0200 Subject: [PATCH] drivers: can: handlers: verify API call in z_vrfy_can_get_state() Verify the get_state API call in z_vrfy_can_get_state(). Adjust sizeof() arguments to match the rest of the file. Signed-off-by: Henrik Brix Andersen --- drivers/can/can_handlers.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/can/can_handlers.c b/drivers/can/can_handlers.c index 12c8da32443..a1481f1831a 100644 --- a/drivers/can/can_handlers.c +++ b/drivers/can/can_handlers.c @@ -143,18 +143,17 @@ static inline void z_vrfy_can_remove_rx_filter(const struct device *dev, int fil } #include -static inline -int z_vrfy_can_get_state(const struct device *dev, enum can_state *state, - struct can_bus_err_cnt *err_cnt) +static inline int z_vrfy_can_get_state(const struct device *dev, enum can_state *state, + struct can_bus_err_cnt *err_cnt) { - Z_OOPS(Z_SYSCALL_OBJ(dev, K_OBJ_DRIVER_CAN)); + Z_OOPS(Z_SYSCALL_DRIVER_CAN(dev, get_state)); if (state != NULL) { - Z_OOPS(Z_SYSCALL_MEMORY_WRITE(state, sizeof(enum can_state))); + Z_OOPS(Z_SYSCALL_MEMORY_WRITE(state, sizeof(*state))); } if (err_cnt != NULL) { - Z_OOPS(Z_SYSCALL_MEMORY_WRITE(err_cnt, sizeof(struct can_bus_err_cnt))); + Z_OOPS(Z_SYSCALL_MEMORY_WRITE(err_cnt, sizeof(*err_cnt))); } return z_impl_can_get_state(dev, state, err_cnt);