From e10904eb3c5b33765f9b4b7960bf7e5737ef801f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Benjamin=20Cab=C3=A9?= Date: Mon, 9 Jun 2025 14:40:29 +0200 Subject: [PATCH] drivers: pinctrl: eos_s3: fix logical OR in pinctrl_eos_s3_configure_pin MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fix incorrect use of bitwise OR operator when checking pull-up and pull-down resistor configuration. Signed-off-by: Benjamin Cabé --- drivers/pinctrl/pinctrl_eos_s3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/pinctrl_eos_s3.c b/drivers/pinctrl/pinctrl_eos_s3.c index 5fcd62711da..d922318ecf2 100644 --- a/drivers/pinctrl/pinctrl_eos_s3.c +++ b/drivers/pinctrl/pinctrl_eos_s3.c @@ -103,7 +103,7 @@ static int pinctrl_eos_s3_configure_pin(const pinctrl_soc_pin_t *pin) WRITE_BIT(reg_value, PAD_PULL_DOWN_BIT, 0); if (pin->high_impedance) { WRITE_BIT(reg_value, PAD_PULL_UP_BIT, 0); - } else if (pin->pull_up | pin->pull_down) { + } else if (pin->pull_up || pin->pull_down) { WRITE_BIT(reg_value, PAD_PULL_UP_BIT, pin->pull_up); WRITE_BIT(reg_value, PAD_PULL_DOWN_BIT, pin->pull_down); }