michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: pinctrl: eos_s3: fix logical OR in pinctrl_eos_s3_configure_pin

Browse source 
Fix incorrect use of bitwise OR operator when checking pull-up and
pull-down resistor configuration.

Signed-off-by: Benjamin Cabé <benjamin@zephyrproject.org>
This commit is contained in:
Benjamin Cabé 2025-06-09 14:40:29 +02:00 • committed by Dan Kalowsky
commit e10904eb3c
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
drivers/pinctrl/pinctrl_eos_s3.c
View file

@ -103,7 +103,7 @@ static int pinctrl_eos_s3_configure_pin(const pinctrl_soc_pin_t *pin)
WRITE_BIT(reg_value, PAD_PULL_DOWN_BIT, 0);
if (pin->high_impedance) {
WRITE_BIT(reg_value, PAD_PULL_UP_BIT, 0);
} else if (pin->pull_up | pin->pull_down) {
} else if (pin->pull_up || pin->pull_down) {
WRITE_BIT(reg_value, PAD_PULL_UP_BIT, pin->pull_up);
WRITE_BIT(reg_value, PAD_PULL_DOWN_BIT, pin->pull_down);
}