michaelh/zephyr
1
0
Fork 0
Code Releases Activity

net: lib: lwm2m: Use defines for update state and result pathstrs

Browse source 
Use defines instead of hardcoded strings to avoid future errors if the
values would change.

Signed-off-by: Andreas Pettersson <andreaspettersson95@gmail.com>
This commit is contained in:
Andreas Pettersson 2022-03-29 10:41:56 +02:00 • committed by Carles Cufí
commit df59335541
1 changed files with 6 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

10
subsys/net/lib/lwm2m/lwm2m_obj_firmware.c
View file

@ -97,7 +97,7 @@ uint8_t lwm2m_firmware_get_update_state(void)
void lwm2m_firmware_set_update_state_inst(uint16_t obj_inst_id, uint8_t state)
{
bool error = false;
char path[sizeof("5/65535/3")];
char path[LWM2M_MAX_PATH_STR_LEN];
/* Check LWM2M SPEC appendix E.6.1 */
switch (state) {
@ -129,7 +129,8 @@ void lwm2m_firmware_set_update_state_inst(uint16_t obj_inst_id, uint8_t state)
update_state[obj_inst_id], state);
}
snprintk(path, sizeof(path), "5/%" PRIu16 "/3", obj_inst_id);
snprintk(path, sizeof(path), "%" PRIu16 "/%" PRIu16 "/%" PRIu16,
LWM2M_OBJECT_FIRMWARE_ID, obj_inst_id, FIRMWARE_STATE_ID);
lwm2m_engine_set_u8(path, state);
@ -155,7 +156,7 @@ void lwm2m_firmware_set_update_result_inst(uint16_t obj_inst_id, uint8_t result)
{
uint8_t state;
bool error = false;
char path[sizeof("5/65535/5")];
char path[LWM2M_MAX_PATH_STR_LEN];
/* Check LWM2M SPEC appendix E.6.1 */
switch (result) {
@ -211,7 +212,8 @@ void lwm2m_firmware_set_update_result_inst(uint16_t obj_inst_id, uint8_t result)
result, state);
}
snprintk(path, sizeof(path), "5/%" PRIu16 "/5", obj_inst_id);
snprintk(path, sizeof(path), "%" PRIu16 "/%" PRIu16 "/%" PRIu16,
LWM2M_OBJECT_FIRMWARE_ID, obj_inst_id, FIRMWARE_UPDATE_RESULT_ID);
lwm2m_engine_set_u8(path, result);