michaelh/zephyr
1
0
Fork 0
Code Releases Activity

tests: latency_measure: fix stacks for the busy threads

Browse source 
The current `K_THREAD_STACK_DEFINE` only create a single stack
shared by all the busy threads. This is causing the application
to crash when there are more than 2 cores in the system.

We should use `K_THREAD_STACK_ARRAY_DEFINE` to create an array
of stacks instead.

Updated the testcase to test up to 8 cores using
qemu_riscv64_smp

Signed-off-by: Yong Cong Sin <ycsin@meta.com>
Signed-off-by: Yong Cong Sin <yongcong.sin@gmail.com>
This commit is contained in:
Yong Cong Sin 2024-09-17 22:23:06 +08:00 • committed by Fabio Baltieri
commit def418b920
3 changed files with 7 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
tests/benchmarks/latency_measure/boards/qemu_riscv64_qemu_virt_riscv64_smp.conf Normal file
View file

@ -0,0 +1,4 @@
CONFIG_MP_MAX_NUM_CPUS=8
# To support the amount of thread objects in userspace
CONFIG_MAX_THREAD_BYTES=3

4
tests/benchmarks/latency_measure/src/main.c
View file

@ -36,7 +36,7 @@ struct k_thread busy_thread[CONFIG_MP_MAX_NUM_CPUS - 1];
#define BUSY_THREAD_STACK_SIZE (1024 + CONFIG_TEST_EXTRA_STACK_SIZE) #define BUSY_THREAD_STACK_SIZE (1024 + CONFIG_TEST_EXTRA_STACK_SIZE)
K_THREAD_STACK_DEFINE(busy_thread_stack, BUSY_THREAD_STACK_SIZE); K_THREAD_STACK_ARRAY_DEFINE(busy_thread_stack, CONFIG_MP_MAX_NUM_CPUS - 1, BUSY_THREAD_STACK_SIZE);
#endif #endif
struct k_thread start_thread; struct k_thread start_thread;
@ -88,7 +88,7 @@ static void test_thread(void *arg1, void *arg2, void *arg3)
/* Spawn busy threads that will execute on the other cores */ /* Spawn busy threads that will execute on the other cores */
for (uint32_t i = 0; i < CONFIG_MP_MAX_NUM_CPUS - 1; i++) { for (uint32_t i = 0; i < CONFIG_MP_MAX_NUM_CPUS - 1; i++) {
k_thread_create(&busy_thread[i], &busy_thread_stack[i], k_thread_create(&busy_thread[i], busy_thread_stack[i],
BUSY_THREAD_STACK_SIZE, busy_thread_entry, BUSY_THREAD_STACK_SIZE, busy_thread_entry,
NULL, NULL, NULL, NULL, NULL, NULL,
K_HIGHEST_THREAD_PRIO, 0, K_NO_WAIT); K_HIGHEST_THREAD_PRIO, 0, K_NO_WAIT);

1
tests/benchmarks/latency_measure/testcase.yaml
View file

@ -13,6 +13,7 @@ tests:
integration_platforms: integration_platforms:
- qemu_x86 - qemu_x86
- qemu_arc/qemu_arc_em - qemu_arc/qemu_arc_em
- qemu_riscv64/qemu_virt_riscv64/smp
harness_config: harness_config:
type: one_line type: one_line
record: record: