michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: mb_display: remove usage of gpio_port_ functions.

Browse source 
gpio_port_ functions are being deprecated. This commit removes their
usage.

Signed-off-by: Piotr Mienkowski <piotr.mienkowski@gmail.com>
This commit is contained in:
Piotr Mienkowski 2019-01-31 23:36:30 +01:00 • committed by Anas Nashif
commit dc6066946e
3 changed files with 9 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

10
drivers/display/Kconfig.microbit
View file

@ -17,16 +17,6 @@ config MICROBIT_DISPLAY
if MICROBIT_DISPLAY
config MICROBIT_DISPLAY_PIN_GRANULARITY
bool "Access the GPIO on a per-pin instead of per-port basis"
help
By default, the micro:bit display driver will update the GPIO
pins of the display (pins 4 through 15) by accessing the entire
GPIO port. This is done for efficiency, however it may interfere
with other peripherals connected to the same GPIO port. Select
this option if other peripherals are connected to the same GPIO
port.
config MICROBIT_DISPLAY_STR_MAX
int "Maximum length of strings that can be shown on the display"
range 3 255

22
drivers/display/mb_display.c
View file

@ -173,22 +173,18 @@ static void start_image(struct mb_display *disp, const struct mb_image *img)
static inline void update_pins(struct mb_display *disp, u32_t val)
{
if (IS_ENABLED(CONFIG_MICROBIT_DISPLAY_PIN_GRANULARITY)) {
u32_t pin, prev = (disp->cur + 2) % 3;
u32_t pin, prev = (disp->cur + 2) % 3;
/* Disable the previous row */
gpio_pin_write(disp->dev, ROW_PIN(prev), 0);
/* Disable the previous row */
gpio_pin_write(disp->dev, ROW_PIN(prev), 0);
/* Set the column pins to their correct values */
for (pin = LED_COL1_GPIO_PIN; pin <= LED_COL9_GPIO_PIN; pin++) {
gpio_pin_write(disp->dev, pin, !!(val & BIT(pin)));
}
/* Enable the new row */
gpio_pin_write(disp->dev, ROW_PIN(disp->cur), 1);
} else {
gpio_port_write(disp->dev, val);
/* Set the column pins to their correct values */
for (pin = LED_COL1_GPIO_PIN; pin <= LED_COL9_GPIO_PIN; pin++) {
gpio_pin_write(disp->dev, pin, !!(val & BIT(pin)));
}
/* Enable the new row */
gpio_pin_write(disp->dev, ROW_PIN(disp->cur), 1);
}
static void reset_display(struct mb_display *disp)

1
samples/boards/bbc_microbit/display/prj.conf
View file

@ -3,4 +3,3 @@ CONFIG_GPIO=y
CONFIG_DISPLAY=y
CONFIG_MICROBIT_DISPLAY=y
CONFIG_SYS_CLOCK_TICKS_PER_SEC=250
#CONFIG_MICROBIT_DISPLAY_PIN_GRANULARITY=y