From d9a3c92b5bc8df6d4ff4178baf2d98fc1d6f57e8 Mon Sep 17 00:00:00 2001 From: Sharron LIU Date: Sun, 22 Jan 2017 15:12:14 +0800 Subject: [PATCH] tests: kernel: mpool: fix assert side effect assert should not contain "i++" which might work differently in a non-debug build. Coverity-CID: 160469 Change-Id: Id8fd50127dd93de1676b812ac0888c9ec2e1b5de Signed-off-by: Sharron LIU --- tests/kernel/mem_pool/test_mpool_api/src/test_mpool_api.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/kernel/mem_pool/test_mpool_api/src/test_mpool_api.c b/tests/kernel/mem_pool/test_mpool_api/src/test_mpool_api.c index 75e30583a53..02736a51d2e 100644 --- a/tests/kernel/mem_pool/test_mpool_api/src/test_mpool_api.c +++ b/tests/kernel/mem_pool/test_mpool_api/src/test_mpool_api.c @@ -94,7 +94,8 @@ void test_mpool_alloc_size(void) assert_true(k_mem_pool_alloc(&kmpool, &block[i], size, K_NO_WAIT) == 0, NULL); assert_not_null(block[i].data, NULL); - assert_true((uint32_t)(block[i++].data) % BLK_ALIGN == 0, NULL); + assert_true((uint32_t)(block[i].data) % BLK_ALIGN == 0, NULL); + i++; size = size >> 2; } while (i--) { @@ -111,7 +112,8 @@ void test_mpool_alloc_size(void) assert_true(k_mem_pool_alloc(&kmpool, &block[i], size, K_NO_WAIT) == 0, NULL); assert_not_null(block[i].data, NULL); - assert_true((uint32_t)(block[i++].data) % BLK_ALIGN == 0, NULL); + assert_true((uint32_t)(block[i].data) % BLK_ALIGN == 0, NULL); + i++; size = size << 2; } while (i--) {