michaelh/zephyr
1
0
Fork 0
Code Releases Activity

tests: gpio_basic_api: simplify handling of callback pin check

Browse source 
Previously the check would fail if a higher pin was present in the
callback set.  Callbacks should only be told about pins that are
relevant to the callback, so reject unless exactly the expected pin
was provided.

Signed-off-by: Peter Bigot <peter.bigot@nordicsemi.no>
This commit is contained in:
Peter Bigot 2019-10-29 11:55:13 -05:00 • committed by Carles Cufí
commit d952861d9f
1 changed files with 2 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

13
tests/drivers/gpio/gpio_basic_api/src/test_callback_trigger.c
View file

@ -18,16 +18,6 @@
static struct drv_data data;
static int cb_cnt;
static int pin_num(u32_t pins)
{
int ret = 0;
while (pins >>= 1) {
ret++;
}
return ret;
}
static void callback(struct device *dev,
struct gpio_callback *gpio_cb, u32_t pins)
{
@ -35,7 +25,8 @@ static void callback(struct device *dev,
struct drv_data, gpio_cb);
/*= checkpoint: pins should be marked with correct pin number bit =*/
zassert_true(pin_num(pins) == PIN_IN, NULL);
zassert_equal(pins, BIT(PIN_IN),
"unexpected pins %x", pins);
++cb_cnt;
TC_PRINT("callback triggered: %d\n", cb_cnt);
if ((cb_cnt == 1)