michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: gpio: fixed - pin toggle (output reading)

Browse source 
Before that fix we read the inpupt register when toggling
gpios. With this fix, we now read the output register for
toggling a pin.

Signed-off-by: Sven Ginka <s.ginka@sensry.de>
This commit is contained in:
Sven Ginka 2025-03-20 16:17:36 +01:00 • committed by Benjamin Cabé
commit d7f6aa2f3c
1 changed files with 6 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

11
drivers/gpio/gpio_sy1xx.c
View file

@ -18,9 +18,10 @@ LOG_MODULE_REGISTER(sy1xx_gpio, CONFIG_GPIO_LOG_LEVEL);
#include <pinctrl_soc.h> #include <pinctrl_soc.h>
#include <zephyr/drivers/pinctrl.h> #include <zephyr/drivers/pinctrl.h>
#define SY1XX_GPIO_GET_OFFS 0x00 #define SY1XX_GPIO_GET_IN_OFFS 0x00
#define SY1XX_GPIO_SET_OFFS 0x1c #define SY1XX_GPIO_GET_OUT_OFFS 0x04
#define SY1XX_GPIO_CLR_OFFS 0x20 #define SY1XX_GPIO_SET_OFFS 0x1c
#define SY1XX_GPIO_CLR_OFFS 0x20
struct sy1xx_gpio_config { struct sy1xx_gpio_config {
/* Base address for GPIO port*/ /* Base address for GPIO port*/
@ -104,7 +105,7 @@ int sy1xx_gpio_driver_port_get_raw(const struct device *dev, gpio_port_value_t *
{ {
const struct sy1xx_gpio_config *const cfg = dev->config; const struct sy1xx_gpio_config *const cfg = dev->config;
*value = sys_read32(cfg->port_base_addr | SY1XX_GPIO_GET_OFFS); *value = sys_read32(cfg->port_base_addr | SY1XX_GPIO_GET_IN_OFFS);
return 0; return 0;
} }
@ -143,7 +144,7 @@ int sy1xx_gpio_driver_port_toggle_bits(const struct device *dev, gpio_port_pins_
{ {
const struct sy1xx_gpio_config *const cfg = dev->config; const struct sy1xx_gpio_config *const cfg = dev->config;
uint32_t current = sys_read32(cfg->port_base_addr | SY1XX_GPIO_GET_OFFS); uint32_t current = sys_read32(cfg->port_base_addr | SY1XX_GPIO_GET_OUT_OFFS);
sy1xx_gpio_driver_port_set_masked_raw(dev, pins, ~current); sy1xx_gpio_driver_port_set_masked_raw(dev, pins, ~current);
return 0; return 0;