michaelh/zephyr
1
0
Fork 0
Code Releases Activity

tests: net: all: check_net_options.sh: Use lowercase for internal vars

Browse source 
This makes it possible to tell at a glance which variables are internal
to the script and which ones are parameters to it, which is very
helpful.

This convention is pretty common. See e.g. Google's shell style guide at
https://google.github.io/styleguide/shell.xml#Naming_Conventions, and
https://github.com/icy/bash-coding-style#naming-and-styles. It's older
than those though.

Signed-off-by: Ulf Magnusson <Ulf.Magnusson@nordicsemi.no>
This commit is contained in:
Ulf Magnusson 2019-11-22 21:23:42 +01:00 • committed by Andrew Boie
commit d748cb6118
1 changed files with 7 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

14
tests/net/all/check_net_options.sh
View file

@ -16,23 +16,23 @@ if [ -z "$1" ]; then
exit exit
fi fi
BUILD_DIR="$1" build_dir="$1"
if [ ! -d $BUILD_DIR ]; then if [ ! -d $build_dir ]; then
echo "Directory $BUILD_DIR not found!" echo "Directory $build_dir not found!"
exit exit
fi fi
KCONFIG_DIR=$BUILD_DIR/rst/doc/reference/kconfig kconfig_dir=$build_dir/rst/doc/reference/kconfig
if [ ! -d $KCONFIG_DIR ]; then if [ ! -d $kconfig_dir ]; then
echo "Kconfig documentation not found at $KCONFIG_DIR" echo "Kconfig documentation not found at $kconfig_dir"
exit exit
fi fi
get_options() get_options()
{ {
cd $KCONFIG_DIR; ls CONFIG_DNS* CONFIG_NET* CONFIG_IEEE802154* | sed 's/\.rst//g' cd $kconfig_dir; ls CONFIG_DNS* CONFIG_NET* CONFIG_IEEE802154* | sed 's/\.rst//g'
} }
get_options | while read opt get_options | while read opt