michaelh/zephyr
1
0
Fork 0
Code Releases Activity

shell: kconfig: Have SHELL_BACKEND_RTT depend on USE_SEGGER_RTT

Browse source 
Have SHELL_BACKEND_RTT depend on USE_SEGGER_RTT instead of selecting it,
to fix some selects of USE_SEGGER_RTT with unsatisfied dependencies.
USE_SEGGER_RTT was being forced on without checking HAS_SEGGER_RTT.

This means configuration files now have to enable both USE_SEGGER_RTT
and SHELL_BACKEND_RTT to enable SHELL_BACKEND_RTT. At least
samples/subsys/shell/shell_module/prj_minimal_rtt.conf does.

(The original version of this commit added a dependency on
HAS_SEGGER_RTT to SHELL_BACKEND_RTT instead, but Krzysztof Chruscinski
suggested depending on USE_SEGGER_RTT instead.)

Footnote: 'depends on' conditions get propagated to properties, so this
change is the same as adding '... if USE_SEGGER_RTT' to all properties
(and the prompt).

Signed-off-by: Ulf Magnusson <Ulf.Magnusson@nordicsemi.no>
This commit is contained in:
Ulf Magnusson 2020-01-21 22:20:03 +01:00 • committed by Carles Cufí
commit d727e6c947
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
subsys/shell/Kconfig.backends
View file

@ -114,9 +114,9 @@ endif # SHELL_BACKEND_SERIAL
config SHELL_BACKEND_RTT
bool "Enable RTT backend"
select USE_SEGGER_RTT
select CONSOLE
select RTT_CONSOLE
depends on USE_SEGGER_RTT
help
Enable RTT backend.