michaelh/zephyr
1
0
Fork 0
Code Releases Activity

samples: usb_c: source: use ENODEV and remove \n use

Browse source 
ENOENT was the wrong return code to use.
Newlines not needed in logs.

Signed-off-by: Nick Ward <nix.ward@gmail.com>
This commit is contained in:
Nick Ward 2023-08-28 21:42:43 +10:00 • committed by Carles Cufí
commit d4e1b186ee
1 changed files with 17 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

34
samples/subsys/usb_c/source/src/power_ctrl.c
View file

@ -90,71 +90,71 @@ static int power_ctrl_init(void)
int ret; int ret;
if (!gpio_is_ready_dt(&source_en)) { if (!gpio_is_ready_dt(&source_en)) {
LOG_ERR("Error: Source Enable device %s is not ready\n", LOG_ERR("Error: Source Enable device %s is not ready",
source_en.port->name); source_en.port->name);
return -ENOENT; return -ENODEV;
} }
if (!gpio_is_ready_dt(&dcdc_en)) { if (!gpio_is_ready_dt(&dcdc_en)) {
LOG_ERR("Error: DCDC Enable device %s is not ready\n", LOG_ERR("Error: DCDC Enable device %s is not ready",
dcdc_en.port->name); dcdc_en.port->name);
return -ENOENT; return -ENODEV;
} }
if (!gpio_is_ready_dt(&vconn1_en)) { if (!gpio_is_ready_dt(&vconn1_en)) {
LOG_ERR("Error: VCONN1 Enable device %s is not ready\n", LOG_ERR("Error: VCONN1 Enable device %s is not ready",
vconn1_en.port->name); vconn1_en.port->name);
return -ENOENT; return -ENODEV;
} }
if (!gpio_is_ready_dt(&vconn2_en)) { if (!gpio_is_ready_dt(&vconn2_en)) {
LOG_ERR("Error: VCONN2 Enable device %s is not ready\n", LOG_ERR("Error: VCONN2 Enable device %s is not ready",
vconn2_en.port->name); vconn2_en.port->name);
return -ENOENT; return -ENODEV;
} }
if (!pwm_is_ready_dt(&pwm_ctl)) { if (!pwm_is_ready_dt(&pwm_ctl)) {
LOG_ERR("Error: PWM CTL device is not ready\n"); LOG_ERR("Error: PWM CTL device is not ready");
return -ENOENT; return -ENODEV;
} }
ret = gpio_pin_configure_dt(&source_en, GPIO_OUTPUT); ret = gpio_pin_configure_dt(&source_en, GPIO_OUTPUT);
if (ret != 0) { if (ret != 0) {
LOG_ERR("Error %d: failed to configure Source Enable device %s pin %d\n", LOG_ERR("Error %d: failed to configure Source Enable device %s pin %d",
ret, source_en.port->name, source_en.pin); ret, source_en.port->name, source_en.pin);
return ret; return ret;
} }
ret = gpio_pin_configure_dt(&dcdc_en, GPIO_OUTPUT); ret = gpio_pin_configure_dt(&dcdc_en, GPIO_OUTPUT);
if (ret != 0) { if (ret != 0) {
LOG_ERR("Error %d: failed to configure DCDC Enable device %s pin %d\n", LOG_ERR("Error %d: failed to configure DCDC Enable device %s pin %d",
ret, dcdc_en.port->name, dcdc_en.pin); ret, dcdc_en.port->name, dcdc_en.pin);
return ret; return ret;
} }
ret = gpio_pin_configure_dt(&vconn1_en, GPIO_OUTPUT | GPIO_OPEN_DRAIN); ret = gpio_pin_configure_dt(&vconn1_en, GPIO_OUTPUT | GPIO_OPEN_DRAIN);
if (ret != 0) { if (ret != 0) {
LOG_ERR("Error %d: failed to configure VCONN1 Enable device %s pin %d\n", LOG_ERR("Error %d: failed to configure VCONN1 Enable device %s pin %d",
ret, vconn1_en.port->name, vconn1_en.pin); ret, vconn1_en.port->name, vconn1_en.pin);
return ret; return ret;
} }
ret = gpio_pin_configure_dt(&vconn2_en, GPIO_OUTPUT | GPIO_OPEN_DRAIN); ret = gpio_pin_configure_dt(&vconn2_en, GPIO_OUTPUT | GPIO_OPEN_DRAIN);
if (ret != 0) { if (ret != 0) {
LOG_ERR("Error %d: failed to configure VCONN2 Enable device %s pin %d\n", LOG_ERR("Error %d: failed to configure VCONN2 Enable device %s pin %d",
ret, vconn2_en.port->name, vconn1_en.pin); ret, vconn2_en.port->name, vconn1_en.pin);
return ret; return ret;
} }
ret = gpio_pin_set_dt(&source_en, 1); ret = gpio_pin_set_dt(&source_en, 1);
if (ret != 0) { if (ret != 0) {
LOG_ERR("Error %d: failed to enable source\n", ret); LOG_ERR("Error %d: failed to enable source", ret);
return ret; return ret;
} }
ret = gpio_pin_set_dt(&dcdc_en, 1); ret = gpio_pin_set_dt(&dcdc_en, 1);
if (ret != 0) { if (ret != 0) {
LOG_ERR("Error %d: failed to enable dcdc converter\n", ret); LOG_ERR("Error %d: failed to enable dcdc converter", ret);
return ret; return ret;
} }
@ -162,7 +162,7 @@ static int power_ctrl_init(void)
ret = source_ctrl_set(SOURCE_0V); ret = source_ctrl_set(SOURCE_0V);
if (ret != 0) { if (ret != 0) {
LOG_ERR("Error %d: failed to set VBUS to 0V\n", ret); LOG_ERR("Error %d: failed to set VBUS to 0V", ret);
return ret; return ret;
} }