michaelh/zephyr
1
0
Fork 0
Code Releases Activity

shell: Fix llvm-clang coverage without backend.

Browse source 
Building this file with CONFIG_COVERAGE=y and CONFIG_SHELL_LOG_BACKEND=n
fails on the llvm-clang compiler. Swapping the IS_ENABLED and
log_backend allows the compiler to optimize out the if block even with
coverage enabled.

Signed-off-by: Jeremy Bettis <jbettis@chromium.org>
This commit is contained in:
Jeremy Bettis 2021-03-17 11:20:26 -06:00 • committed by Kumar Gala
commit d4316cc483
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
subsys/shell/shell.c
View file

@ -1249,7 +1249,7 @@ void shell_thread(void *shell_handle, void *arg_log_backend,
return;
}
if (log_backend && IS_ENABLED(CONFIG_SHELL_LOG_BACKEND)) {
if (IS_ENABLED(CONFIG_SHELL_LOG_BACKEND) && log_backend) {
z_shell_log_backend_enable(shell->log_backend, (void *)shell,
log_level);
}