michaelh/zephyr
1
0
Fork 0
Code Releases Activity

Bluetooth: BAP: Shell: Add tracking of empty SDUs

Browse source 
There are devices that will send empty SDUs instead of
empty PDUs, and while that should be harmless, it is nice
to know what is going on, and we may want to deal with
empty SDUs and empty PDUs differently.

This also modifies the state for TS and PSN to only be
applied for valid ISO packets.

Signed-off-by: Emil Gydesen <emil.gydesen@nordicsemi.no>
This commit is contained in:
Emil Gydesen 2024-03-26 11:58:46 +01:00 • committed by Anas Nashif
commit d229b89a2b
2 changed files with 22 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

1
subsys/bluetooth/audio/shell/audio.h
View file

@ -85,6 +85,7 @@ struct shell_stream {
#endif /* CONFIG_BT_AUDIO_TX */
#if defined(CONFIG_BT_AUDIO_RX)
struct bt_iso_recv_info last_info;
size_t empty_sdu_pkts;
size_t lost_pkts;
size_t err_pkts;
size_t dup_psn;

32
subsys/bluetooth/audio/shell/bap.c
View file

@ -2338,12 +2338,20 @@ static void audio_recv(struct bt_bap_stream *stream,
sh_stream->rx_cnt++;
if (info->ts == sh_stream->last_info.ts) {
sh_stream->dup_ts++;
}
if ((info->flags & BT_ISO_FLAGS_VALID) != 0) {
/* For valid ISO packets we check if they are invalid in other ways */
if (info->seq_num == sh_stream->last_info.seq_num) {
sh_stream->dup_psn++;
if (info->ts == sh_stream->last_info.ts) {
sh_stream->dup_ts++;
}
if (info->seq_num == sh_stream->last_info.seq_num) {
sh_stream->dup_psn++;
}
if (buf->len == 0U) {
sh_stream->empty_sdu_pkts++;
}
}
if (info->flags & BT_ISO_FLAGS_ERROR) {
@ -2355,12 +2363,13 @@ static void audio_recv(struct bt_bap_stream *stream,
}
if ((sh_stream->rx_cnt % recv_stats_interval) == 0) {
shell_print(ctx_shell,
"[%zu]: Incoming audio on stream %p len %u ts %u seq_num %u flags %u "
"(dup ts %zu; dup psn %zu, err_pkts %zu, lost_pkts %zu)",
sh_stream->rx_cnt, stream, buf->len, info->ts, info->seq_num,
info->flags, sh_stream->dup_ts, sh_stream->dup_psn, sh_stream->err_pkts,
sh_stream->lost_pkts);
shell_print(
ctx_shell,
"[%zu]: Incoming audio on stream %p len %u ts %u seq_num %u flags %u "
"(dup ts %zu; dup psn %zu, err_pkts %zu, lost_pkts %zu, empty SDUs %zu)",
sh_stream->rx_cnt, stream, buf->len, info->ts, info->seq_num, info->flags,
sh_stream->dup_ts, sh_stream->dup_psn, sh_stream->err_pkts,
sh_stream->lost_pkts, sh_stream->empty_sdu_pkts);
}
(void)memcpy(&sh_stream->last_info, info, sizeof(sh_stream->last_info));
@ -2421,6 +2430,7 @@ static void stream_started_cb(struct bt_bap_stream *bap_stream)
printk("Stream %p started\n", bap_stream);
#if defined(CONFIG_BT_AUDIO_RX)
sh_stream->empty_sdu_pkts = 0U;
sh_stream->lost_pkts = 0U;
sh_stream->err_pkts = 0U;
sh_stream->dup_psn = 0U;