michaelh/zephyr
1
0
Fork 0
Code Releases Activity

rtc: dw: Unmasking interrupt is not generic among platforms

Browse source 
Let's apply the interruption unmasking if only the mask is defined.
Which definition should be done in board.h thus applying the change to
quark_se and quark_d2000 platforms

Change-Id: I9c273e2e7e33dd077a54e8f9205fa949a5e3707a
Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
This commit is contained in:
Tomasz Bursztyka 2015-12-03 12:16:30 +01:00 • committed by Anas Nashif
commit d1d66a6200
3 changed files with 14 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
arch/x86/platforms/quark_d2000/board.h
View file

@ -134,8 +134,8 @@ struct scss_interrupt {
/* RTC */
#define RTC_DW_INT_MASK (SCSS_INT_BASE + 0x78)
#define CCU_RTC_CLK_DIV_OFFSET 0x3
#define INT_RTC_MASK 0x478
#define CCU_RTC_PCLK_EN_SW (1 << 11)

2
arch/x86/platforms/quark_se/board.h
View file

@ -225,8 +225,8 @@ struct scss_interrupt {
#define CCU_WDT_PCLK_EN_SW (1 << 10)
/* RTC */
#define RTC_DW_INT_MASK (SCSS_INT_BASE + 0x78)
#define CCU_RTC_CLK_DIV_OFFSET (3)
#define SCSS_INT_RTC_MASK 0x478
#define CCU_RTC_PCLK_EN_SW (1 << 11)
/* Clock */

13
drivers/rtc/rtc_dw.c
View file

@ -26,6 +26,16 @@
#define CLK_RTC_DIV_DEF_MASK (0xFFFFFF83)
#define CCU_RTC_CLK_DIV_EN (2)
#ifdef RTC_DW_INT_MASK
static inline void _rtc_dw_int_unmask(void)
{
sys_write32(sys_read32(RTC_DW_INT_MASK) & INT_UNMASK_IA,
RTC_DW_INT_MASK);
}
#else
#define _rtc_dw_int_unmask()
#endif
static void rtc_dw_set_div(const enum clk_rtc_div div)
{
/* set default division mask */
@ -157,7 +167,8 @@ int rtc_dw_init(struct device *dev)
IRQ_CONFIG(rtc, CONFIG_RTC_DW_IRQ);
irq_enable(CONFIG_RTC_DW_IRQ);
SCSS_INTERRUPT->int_rtc_mask = INT_UNMASK_IA;
_rtc_dw_int_unmask();
dev->driver_api = &funcs;
return DEV_OK;