michaelh/zephyr
1
0
Fork 0
Code Releases Activity

Bluetooth: controller: Use sys_le16_to_cpu on all commands

Browse source 
To guarantee code that is endianness-independent, the sys_le* macros
must be used everywhere when accessing multi-byte values from the
command parameters.

Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
This commit is contained in:
Carles Cufi 2017-05-05 11:40:59 +02:00 • committed by Johan Hedberg
commit cff44ea3f6
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
subsys/bluetooth/controller/hci/hci.c
View file

@ -239,9 +239,9 @@ static void set_ctl_to_host_flow(struct net_buf *buf, struct net_buf **evt)
static void host_buffer_size(struct net_buf *buf, struct net_buf **evt) static void host_buffer_size(struct net_buf *buf, struct net_buf **evt)
{ {
struct bt_hci_cp_host_buffer_size *cmd = (void *)buf->data; struct bt_hci_cp_host_buffer_size *cmd = (void *)buf->data;
u16_t acl_pkts = sys_le16_to_cpu(cmd->acl_pkts);
u16_t acl_mtu = sys_le16_to_cpu(cmd->acl_mtu);
struct bt_hci_evt_cc_status *ccst; struct bt_hci_evt_cc_status *ccst;
u16_t acl_pkts = cmd->acl_pkts;
u16_t acl_mtu = cmd->acl_pkts;
ccst = cmd_complete(evt, sizeof(*ccst)); ccst = cmd_complete(evt, sizeof(*ccst));
@ -281,7 +281,7 @@ static void host_num_completed_packets(struct net_buf *buf,
/* leave *evt == NULL so no event is generated */ /* leave *evt == NULL so no event is generated */
for (i = 0; i < cmd->num_handles; i++) { for (i = 0; i < cmd->num_handles; i++) {
count += cmd->h[i].count; count += sys_le16_to_cpu(cmd->h[i].count);
} }
hci_hbuf_acked += count; hci_hbuf_acked += count;