michaelh/zephyr
1
0
Fork 0
Code Releases Activity

twister: do not error on intentionally skipped tests

Browse source 
if we mark a test to be skipped, do not error in integration mode about
filter conflicts.

Signed-off-by: Anas Nashif <anas.nashif@intel.com>
This commit is contained in:
Anas Nashif 2022-10-12 20:19:43 -04:00
commit cc7d337ea7
1 changed files with 5 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

8
scripts/pylib/twister/twisterlib/testplan.py
View file

@ -51,8 +51,10 @@ class Filters:
TESTSUITE = 'testsuite filter'
# filters realted to platform definition
PLATFORM = 'Platform related filter'
# in case a testcase was quarantined.
# in case a test suite was quarantined.
QUARENTINE = 'Quarantine filter'
# in case a test suite is skipped intentionally .
SKIP = 'Skip filter'
class TestPlan:
@ -663,7 +665,7 @@ class TestPlan:
instance.add_filter("Not part of integration platforms", Filters.TESTSUITE)
if ts.skip:
instance.add_filter("Skip filter", Filters.TESTSUITE)
instance.add_filter("Skip filter", Filters.SKIP)
if tag_filter and not ts.tags.intersection(tag_filter):
instance.add_filter("Command line testsuite tag filter", Filters.CMD_LINE)
@ -784,7 +786,7 @@ class TestPlan:
and "Quarantine" not in filtered_instance.reason:
# Do not treat this as error if filter type is command line
filters = {t['type'] for t in filtered_instance.filters}
if Filters.CMD_LINE in filters:
if Filters.CMD_LINE in filters or Filters.SKIP in filters:
continue
filtered_instance.status = "error"
filtered_instance.reason += " but is one of the integration platforms"