michaelh/zephyr
1
0
Fork 0
Code Releases Activity

tests: Bluetooth: Fix incorrect comments about adv sets

Browse source 
Several places we simply had
/* Create a non-connectable non-scannable advertising set */
regardless of the type of advertising it was.

Modified the comment to omit the scannable part
and corrected the connectable part.

Signed-off-by: Emil Gydesen <emil.gydesen@nordicsemi.no>
This commit is contained in:
Emil Gydesen 2024-05-22 13:03:49 +02:00 • committed by Anas Nashif
commit cc602a6941
8 changed files with 8 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

2
tests/bsim/bluetooth/audio/src/bap_bass_broadcaster_test.c
View file

@ -31,7 +31,7 @@ static void test_main(void)
printk("Bluetooth initialized\n"); printk("Bluetooth initialized\n");
/* Create a non-connectable non-scannable advertising set */ /* Create a non-connectable advertising set */
err = bt_le_ext_adv_create(BT_LE_EXT_ADV_NCONN, NULL, &adv); err = bt_le_ext_adv_create(BT_LE_EXT_ADV_NCONN, NULL, &adv);
if (err) { if (err) {
FAIL("Failed to create advertising set (err %d)\n", err); FAIL("Failed to create advertising set (err %d)\n", err);

2
tests/bsim/bluetooth/audio/src/bap_broadcast_sink_test.c
View file

@ -898,7 +898,7 @@ static void test_start_adv(void)
}; };
int err; int err;
/* Create a non-connectable non-scannable advertising set */ /* Create a connectable advertising set */
err = bt_le_ext_adv_create(BT_LE_EXT_ADV_CONN, NULL, &ext_adv); err = bt_le_ext_adv_create(BT_LE_EXT_ADV_CONN, NULL, &ext_adv);
if (err != 0) { if (err != 0) {
FAIL("Failed to create advertising set (err %d)\n", err); FAIL("Failed to create advertising set (err %d)\n", err);

2
tests/bsim/bluetooth/audio/src/bap_broadcast_source_test.c
View file

@ -221,7 +221,7 @@ static int setup_extended_adv(struct bt_bap_broadcast_source *source, struct bt_
uint32_t broadcast_id; uint32_t broadcast_id;
int err; int err;
/* Create a non-connectable non-scannable advertising set */ /* Create a non-connectable advertising set */
err = bt_le_ext_adv_create(&adv_param, NULL, adv); err = bt_le_ext_adv_create(&adv_param, NULL, adv);
if (err != 0) { if (err != 0) {
printk("Unable to create extended advertising set: %d\n", err); printk("Unable to create extended advertising set: %d\n", err);

2
tests/bsim/bluetooth/audio/src/bap_unicast_server_test.c
View file

@ -490,7 +490,7 @@ static void init(void)
&stream_ops); &stream_ops);
} }
/* Create a non-connectable non-scannable advertising set */ /* Create a connectable advertising set */
err = bt_le_ext_adv_create(BT_LE_EXT_ADV_CONN, NULL, &ext_adv); err = bt_le_ext_adv_create(BT_LE_EXT_ADV_CONN, NULL, &ext_adv);
if (err != 0) { if (err != 0) {
FAIL("Failed to create advertising set (err %d)\n", err); FAIL("Failed to create advertising set (err %d)\n", err);

2
tests/bsim/bluetooth/audio/src/cap_initiator_broadcast_test.c
View file

@ -184,7 +184,7 @@ static void setup_extended_adv(struct bt_le_ext_adv **adv)
{ {
int err; int err;
/* Create a non-connectable non-scannable advertising set */ /* Create a non-connectable advertising set */
err = bt_le_ext_adv_create(BT_LE_EXT_ADV_CUSTOM, NULL, adv); err = bt_le_ext_adv_create(BT_LE_EXT_ADV_CUSTOM, NULL, adv);
if (err != 0) { if (err != 0) {
FAIL("Unable to create extended advertising set: %d\n", err); FAIL("Unable to create extended advertising set: %d\n", err);

2
tests/bsim/bluetooth/audio/src/gmap_ugg_test.c
View file

@ -1006,7 +1006,7 @@ static void setup_extended_adv(struct bt_le_ext_adv **adv)
{ {
int err; int err;
/* Create a non-connectable non-scannable advertising set */ /* Create a non-connectable advertising set */
err = bt_le_ext_adv_create(BT_LE_EXT_ADV_CUSTOM, NULL, adv); err = bt_le_ext_adv_create(BT_LE_EXT_ADV_CUSTOM, NULL, adv);
if (err != 0) { if (err != 0) {
FAIL("Unable to create extended advertising set: %d\n", err); FAIL("Unable to create extended advertising set: %d\n", err);

2
tests/bsim/bluetooth/audio/src/pbp_public_broadcast_source_test.c
View file

@ -216,7 +216,7 @@ static int setup_extended_adv(struct bt_le_ext_adv **adv)
{ {
int err; int err;
/* Create a non-connectable non-scannable advertising set */ /* Create a non-connectable advertising set */
err = bt_le_ext_adv_create(BT_LE_EXT_ADV_NCONN, NULL, adv); err = bt_le_ext_adv_create(BT_LE_EXT_ADV_NCONN, NULL, adv);
if (err != 0) { if (err != 0) {
printk("Unable to create extended advertising set: %d\n", err); printk("Unable to create extended advertising set: %d\n", err);

2
tests/bsim/bluetooth/host/iso/bis/src/bis_broadcaster.c
View file

@ -155,7 +155,7 @@ static void create_ext_adv(struct bt_le_ext_adv **adv)
LOG_INF("Creating extended advertising set with periodic advertising"); LOG_INF("Creating extended advertising set with periodic advertising");
/* Create a non-connectable non-scannable advertising set */ /* Create a non-connectable advertising set */
err = bt_le_ext_adv_create(BT_LE_EXT_ADV_NCONN, NULL, adv); err = bt_le_ext_adv_create(BT_LE_EXT_ADV_NCONN, NULL, adv);
TEST_ASSERT(err == 0, "Unable to create extended advertising set: %d", err); TEST_ASSERT(err == 0, "Unable to create extended advertising set: %d", err);