From cbeac3e97db5a658f9f99d38c23dad1baa6420c8 Mon Sep 17 00:00:00 2001 From: Qiu Peiyang Date: Mon, 23 Jan 2017 13:38:20 +0800 Subject: [PATCH] tests/gpio: don't call risk function According to Coverity, rand() is a risk function. So we use another method to generate random value. Coverity-CID: 160070 Change-Id: Icb7e06cd43cb8bade6596cc37e9d04bfc59e1de7 Signed-off-by: Qiu Peiyang --- tests/drivers/gpio/gpio_basic_api/prj.conf | 3 ++- tests/drivers/gpio/gpio_basic_api/src/test_pin_rw.c | 3 +-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/drivers/gpio/gpio_basic_api/prj.conf b/tests/drivers/gpio/gpio_basic_api/prj.conf index efa56dbe4b8..af5eeabb13e 100644 --- a/tests/drivers/gpio/gpio_basic_api/prj.conf +++ b/tests/drivers/gpio/gpio_basic_api/prj.conf @@ -1,3 +1,4 @@ CONFIG_GPIO=y CONFIG_ZTEST=y -CONFIG_NEWLIB_LIBC=y +CONFIG_RANDOM_GENERATOR=y +CONFIG_TEST_RANDOM_GENERATOR=y diff --git a/tests/drivers/gpio/gpio_basic_api/src/test_pin_rw.c b/tests/drivers/gpio/gpio_basic_api/src/test_pin_rw.c index 85da6138507..931659fe036 100644 --- a/tests/drivers/gpio/gpio_basic_api/src/test_pin_rw.c +++ b/tests/drivers/gpio/gpio_basic_api/src/test_pin_rw.c @@ -12,7 +12,6 @@ * @} */ -#include #include #include "test_gpio.h" @@ -32,7 +31,7 @@ void test_gpio_pin_read_write(void) int i = 0; while (i++ < 32) { - val_write = rand() % 2; + val_write = sys_rand32_get() / 3 % 2; assert_true(gpio_pin_write(dev, PIN_OUT, val_write) == 0, "write data fail"); TC_PRINT("write: %" PRIu32 "\n", val_write);