michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: wifi: eswifi: Fix coverity issues

Browse source 
This patch fixes the following issues:
CID 190622 (#1 of 1): Out-of-bounds access (OVERRUN)
CID 190632 (#1 of 1): Out-of-bounds access (OVERRUN)
CID 190623 (#1 of 1): Unchecked return value (CHECKED_RETURN)
CID 190628 (#1 of 1): Out-of-bounds write (OVERRUN)
CID 190620 (#1 of 1): Dereference after null check (FORWARD_NULL)

Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
This commit is contained in:
Loic Poulain 2019-01-07 18:40:02 +01:00 • committed by Anas Nashif
commit c9a9e0a4ee
2 changed files with 7 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

9
drivers/wifi/eswifi/eswifi_core.c
View file

@ -45,9 +45,8 @@ static int eswifi_reset(struct eswifi_dev *eswifi)
k_sleep(500); k_sleep(500);
/* fetch the cursor */ /* fetch the cursor */
eswifi_request(eswifi, NULL, 0, eswifi->buf, sizeof(eswifi->buf)); return eswifi_request(eswifi, NULL, 0, eswifi->buf,
sizeof(eswifi->buf));
return 0;
} }
static inline int __parse_ssid(char *str, char *ssid) static inline int __parse_ssid(char *str, char *ssid)
@ -328,7 +327,7 @@ static int eswifi_get_mac_addr(struct eswifi_dev *eswifi, u8_t addr[6])
return err; return err;
} }
for (i = 0; i < sizeof(eswifi->buf); i++) { for (i = 0; i < sizeof(eswifi->buf) && byte < 6; i++) {
if (i < 2) { if (i < 2) {
continue; continue;
} }
@ -466,6 +465,7 @@ static int eswifi_init(struct device *dev)
if (!eswifi->resetn.dev) { if (!eswifi->resetn.dev) {
LOG_ERR("Failed to initialize GPIO driver: %s", LOG_ERR("Failed to initialize GPIO driver: %s",
DT_INVENTEK_ESWIFI_ESWIFI0_RESETN_GPIOS_CONTROLLER); DT_INVENTEK_ESWIFI_ESWIFI0_RESETN_GPIOS_CONTROLLER);
return -ENODEV;
} }
eswifi->resetn.pin = DT_INVENTEK_ESWIFI_ESWIFI0_RESETN_GPIOS_PIN; eswifi->resetn.pin = DT_INVENTEK_ESWIFI_ESWIFI0_RESETN_GPIOS_PIN;
gpio_pin_configure(eswifi->resetn.dev, eswifi->resetn.pin, gpio_pin_configure(eswifi->resetn.dev, eswifi->resetn.pin,
@ -476,6 +476,7 @@ static int eswifi_init(struct device *dev)
if (!eswifi->wakeup.dev) { if (!eswifi->wakeup.dev) {
LOG_ERR("Failed to initialize GPIO driver: %s", LOG_ERR("Failed to initialize GPIO driver: %s",
DT_INVENTEK_ESWIFI_ESWIFI0_WAKEUP_GPIOS_CONTROLLER); DT_INVENTEK_ESWIFI_ESWIFI0_WAKEUP_GPIOS_CONTROLLER);
return -ENODEV;
} }
eswifi->wakeup.pin = DT_INVENTEK_ESWIFI_ESWIFI0_WAKEUP_GPIOS_PIN; eswifi->wakeup.pin = DT_INVENTEK_ESWIFI_ESWIFI0_WAKEUP_GPIOS_PIN;
gpio_pin_configure(eswifi->wakeup.dev, eswifi->wakeup.pin, gpio_pin_configure(eswifi->wakeup.dev, eswifi->wakeup.pin,

4
drivers/wifi/eswifi/eswifi_offload.c
View file

@ -43,7 +43,7 @@ static int __read_data(struct eswifi_dev *eswifi, size_t len)
int err, i, read = 0; int err, i, read = 0;
/* Set max read size */ /* Set max read size */
snprintf(size, sizeof(eswifi->buf), "R1=%u\r", len); snprintf(size, sizeof(size), "R1=%u\r", len);
err = eswifi_request(eswifi, size, strlen(size), err = eswifi_request(eswifi, size, strlen(size),
eswifi->buf, sizeof(eswifi->buf)); eswifi->buf, sizeof(eswifi->buf));
if (err || !eswifi_is_buf_at_ok(eswifi->buf)) { if (err || !eswifi_is_buf_at_ok(eswifi->buf)) {
@ -52,7 +52,7 @@ static int __read_data(struct eswifi_dev *eswifi, size_t len)
} }
/* Set timeout */ /* Set timeout */
snprintf(timeout, sizeof(eswifi->buf), "R2=%u\r", 30); /* 30 ms */ snprintf(timeout, sizeof(timeout), "R2=%u\r", 30); /* 30 ms */
err = eswifi_request(eswifi, timeout, strlen(timeout), err = eswifi_request(eswifi, timeout, strlen(timeout),
eswifi->buf, sizeof(eswifi->buf)); eswifi->buf, sizeof(eswifi->buf));
if (err || !eswifi_is_buf_at_ok(eswifi->buf)) { if (err || !eswifi_is_buf_at_ok(eswifi->buf)) {