michaelh/zephyr
1
0
Fork 0
Code Releases Activity

twister: remove unused arguments in reporting functions

Browse source 
Remove unused arguments that became obsolete through the refactoring.
- filter_status
- only_failed
- json_report

Signed-off-by: Anas Nashif <anas.nashif@intel.com>
This commit is contained in:
Anas Nashif 2022-03-30 12:47:06 -04:00
commit c820ffe18c
2 changed files with 6 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

5
scripts/pylib/twister/twisterlib.py
View file

@ -3264,7 +3264,7 @@ class TestPlan(DisablePyTestCollectionMixin):
logger.info(f"{Fore.GREEN}{run}{Fore.RESET} test configurations executed on platforms, \ logger.info(f"{Fore.GREEN}{run}{Fore.RESET} test configurations executed on platforms, \
{Fore.RED}{results.total - run - results.skipped_configs}{Fore.RESET} test configurations were only built.") {Fore.RED}{results.total - run - results.skipped_configs}{Fore.RESET} test configurations were only built.")
def save_reports(self, name, suffix, report_dir, no_update, only_failed, platform_reports, json_report): def save_reports(self, name, suffix, report_dir, no_update, platform_reports):
if not self.instances: if not self.instances:
return return
@ -3470,8 +3470,7 @@ class TestPlan(DisablePyTestCollectionMixin):
for d in quarantine_list: for d in quarantine_list:
self.quarantine.update(d) self.quarantine.update(d)
# FIXME def load_from_file(self, file, filter_platform=[]):
def load_from_file(self, file, filter_status=[], filter_platform=[]):
with open(file, "r") as json_test_plan: with open(file, "r") as json_test_plan:
jtp = json.load(json_test_plan) jtp = json.load(json_test_plan)
instance_list = [] instance_list = []

11
scripts/twister
View file

@ -1094,10 +1094,10 @@ def main():
tplan.quarantine_verify = options.quarantine_verify tplan.quarantine_verify = options.quarantine_verify
if options.only_failed: if options.only_failed:
tplan.load_from_file(last_run, filter_status=['skipped', 'passed', 'filtered']) tplan.load_from_file(last_run)
tplan.selected_platforms = set(p.platform.name for p in tplan.instances.values()) tplan.selected_platforms = set(p.platform.name for p in tplan.instances.values())
elif options.load_tests: elif options.load_tests:
tplan.load_from_file(options.load_tests, filter_status=['skipped', 'error', 'filtered']) tplan.load_from_file(options.load_tests)
tplan.selected_platforms = set(p.platform.name for p in tplan.instances.values()) tplan.selected_platforms = set(p.platform.name for p in tplan.instances.values())
elif options.test_only: elif options.test_only:
# Get list of connected hardware and filter tests to only be run on connected hardware # Get list of connected hardware and filter tests to only be run on connected hardware
@ -1109,8 +1109,7 @@ def main():
if connected['connected']: if connected['connected']:
connected_list.append(connected['platform']) connected_list.append(connected['platform'])
tplan.load_from_file(last_run, filter_status=['skipped', 'error'], tplan.load_from_file(last_run, filter_platform=connected_list)
filter_platform=connected_list)
tplan.selected_platforms = set(p.platform.name for p in tplan.instances.values()) tplan.selected_platforms = set(p.platform.name for p in tplan.instances.values())
else: else:
tplan.apply_filters( tplan.apply_filters(
@ -1351,9 +1350,7 @@ def main():
options.report_suffix, options.report_suffix,
options.report_dir, options.report_dir,
options.no_update, options.no_update,
options.only_failed, options.platform_reports
options.platform_reports,
options.json_report
) )
logger.info("Run completed") logger.info("Run completed")