From c6f2b4ccb8289bedfa9af2a70c9fd9f7b49ceba5 Mon Sep 17 00:00:00 2001 From: Maureen Helm Date: Tue, 1 May 2018 16:43:46 -0500 Subject: [PATCH] spi: Fix mcux dspi driver to parse lsb transfer mode correctly The mcux dspi driver was incorrectly using the macro SPI_MODE_GET() to parse the operation for SPI_TRANSFER_LSB. The effect of this bug was that the driver would quietly always operate in SPI_TRANSFER_MSB mode. Coverity-CID: 185401 Signed-off-by: Maureen Helm --- drivers/spi/spi_mcux_dspi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi_mcux_dspi.c b/drivers/spi/spi_mcux_dspi.c index 793752e63c7..0ea5da24468 100644 --- a/drivers/spi/spi_mcux_dspi.c +++ b/drivers/spi/spi_mcux_dspi.c @@ -154,7 +154,7 @@ static int spi_mcux_configure(struct device *dev, : kDSPI_ClockPhaseFirstEdge; master_config.ctarConfig.direction = - (SPI_MODE_GET(spi_cfg->operation) & SPI_TRANSFER_LSB) + (spi_cfg->operation & SPI_TRANSFER_LSB) ? kDSPI_LsbFirst : kDSPI_MsbFirst;