From c6e27a05c26c4882efea8481d2a250dfda232a98 Mon Sep 17 00:00:00 2001 From: Andy Ross Date: Wed, 22 Feb 2017 09:39:27 -0800 Subject: [PATCH] quark_se: Don't enable UART 0 always The defconfigs would always create a device for UART 0, which is problematic in circumstances where both the x86 and ARC cores are alive and one wants to use it in a non-default configuration. Specifically: on Arduino 101 this is the bluetooth device and it operates at 1MBps instead of of 115200kbps. If an x86 app sets this up correctly, but then starts the ARC core running an app which doesn't reference this UART at all, the device will still exist and set up the (wrong!) configuration, clobbering the correct settings. Just remove the "def-bool y" bits from the defconfig. There's no need, users of these devices (e.g. the console) will enable them anyway. There's no value to compiling it in without a configured user. Issue: ZEP-1677 Change-Id: I4a0e944f23705495433e9f3d0459065f131579cb Signed-off-by: Andy Ross --- arch/arc/soc/quark_se_c1000_ss/Kconfig.defconfig | 2 -- arch/x86/soc/intel_quark/quark_se/Kconfig.defconfig.series | 2 -- 2 files changed, 4 deletions(-) diff --git a/arch/arc/soc/quark_se_c1000_ss/Kconfig.defconfig b/arch/arc/soc/quark_se_c1000_ss/Kconfig.defconfig index 6a0227e4f98..6f85456a78f 100644 --- a/arch/arc/soc/quark_se_c1000_ss/Kconfig.defconfig +++ b/arch/arc/soc/quark_se_c1000_ss/Kconfig.defconfig @@ -225,8 +225,6 @@ endif if UART_QMSI -config UART_QMSI_0 - def_bool y if UART_QMSI_0 diff --git a/arch/x86/soc/intel_quark/quark_se/Kconfig.defconfig.series b/arch/x86/soc/intel_quark/quark_se/Kconfig.defconfig.series index fcabdef7176..7d96dabce01 100644 --- a/arch/x86/soc/intel_quark/quark_se/Kconfig.defconfig.series +++ b/arch/x86/soc/intel_quark/quark_se/Kconfig.defconfig.series @@ -187,8 +187,6 @@ config RTC_0_IRQ_PRI endif # RTC if UART_QMSI -config UART_QMSI_0 - def_bool y if UART_QMSI_0