michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: GPIO: Microchip: Fix GPIO interrupt enable spurious interrupt

Browse source 
Fix for issue 34879.
Microchip MEC GPIO hardware can trigger a spurious interrupt when
interrupt detection is set to edge mode especially falling edge mode.
Clearing the status immediately after enabling interrupt detection does
not work because the hardware takes a small number of AHB clocks to
set the status. After interrupt detection enable we use an ARM data
memory barrier to insure the write completes before clearing spurious
status and enabling the interrupt in the GIRQ.

Signed-off-by: Scott Worley <scott.worley@microchip.com>
This commit is contained in:
Scott Worley 2021-07-22 09:57:41 -04:00 • committed by Carles Cufí
commit c66250f5ba
1 changed files with 5 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

5
drivers/gpio/gpio_mchp_xec.c
View file

@ -13,6 +13,10 @@
#include "gpio_utils.h" #include "gpio_utils.h"
#define XEC_GPIO_EDGE_DLY_COUNT 8
/* read only register in same AHB segmment for dummy writes */
#define XEC_GPIO_DLY_ADDR 0x40080150u
#define GPIO_IN_BASE(config) \ #define GPIO_IN_BASE(config) \
((__IO uint32_t *)(GPIO_PARIN_BASE + (config->port_num << 2))) ((__IO uint32_t *)(GPIO_PARIN_BASE + (config->port_num << 2)))
@ -211,6 +215,7 @@ static int gpio_xec_pin_interrupt_configure(const struct device *dev,
*/ */
current_pcr1 = config->pcr1_base + pin; current_pcr1 = config->pcr1_base + pin;
*current_pcr1 = (*current_pcr1 & ~mask) | pcr1; *current_pcr1 = (*current_pcr1 & ~mask) | pcr1;
__DMB(); /* insure write completes */
if (mode != GPIO_INT_MODE_DISABLED) { if (mode != GPIO_INT_MODE_DISABLED) {
/* We enable the interrupts in the EC aggregator so that the /* We enable the interrupts in the EC aggregator so that the