michaelh/zephyr
1
0
Fork 0
Code Releases Activity

BLuetooth: Controller: llcp: Fix wrong conditions in remote CTE req

Browse source 
There were wrong conditions in rp_comm_tx function for CTE request
that vefiry if:
- PHY is allowed one,
- CTE length is within allowed value.

The commit fixes it.

Signed-off-by: Piotr Pryga <piotr.pryga@nordicsemi.no>
This commit is contained in:
Piotr Pryga 2022-01-04 09:01:17 +01:00 • committed by Christopher Friedt
commit c50b474e01
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
subsys/bluetooth/controller/ll_sw/ull_llcp_common.c
View file

@ -748,12 +748,12 @@ static void rp_comm_tx(struct ll_conn *conn, struct proc_ctx *ctx)
/* If the PHY update is not possible, then PHY1M is used. /* If the PHY update is not possible, then PHY1M is used.
* CTE is supported for PHY1M. * CTE is supported for PHY1M.
*/ */
if (conn->lll.phy_tx != PHY_CODED) { if (conn->lll.phy_tx == PHY_CODED) {
err_code = BT_HCI_ERR_INVALID_LL_PARAM; err_code = BT_HCI_ERR_INVALID_LL_PARAM;
} }
#endif /* CONFIG_BT_PHY_UPDATE */ #endif /* CONFIG_BT_PHY_UPDATE */
if (!(conn->llcp.cte_rsp.cte_types & BIT(conn->llcp.cte_req.cte_type)) && if (!(conn->llcp.cte_rsp.cte_types & BIT(conn->llcp.cte_req.cte_type)) &&
conn->llcp.cte_rsp.max_cte_len >= conn->llcp.cte_req.min_cte_len) { conn->llcp.cte_rsp.max_cte_len < conn->llcp.cte_req.min_cte_len) {
err_code = BT_HCI_ERR_UNSUPP_LL_PARAM_VAL; err_code = BT_HCI_ERR_UNSUPP_LL_PARAM_VAL;
} }