michaelh/zephyr
1
0
Fork 0
Code Releases Activity

shell: fix i2c commands definitions

Browse source 
I2C scan and recover functions didn't have mandatory parameters
specified, which resulted in not displaying the I2C controllers in
help message. Instead, the command was executed, and argv was
dereferenced outside of the bounds, providing invalid data to
device_get_binding function.
Other functions had defined mandatory parameters without taking their
names into account, they are provided as argv[0].

Signed-off-by: Michał Barnaś <mb@semihalf.com>
This commit is contained in:
Michał Barnaś 2022-01-17 13:40:39 +01:00 • committed by Maureen Helm
commit c2f9e2b0d5
1 changed files with 10 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

18
drivers/i2c/i2c_shell.c
View file

@ -247,22 +247,24 @@ static void device_name_get(size_t idx, struct shell_static_entry *entry)
}
SHELL_STATIC_SUBCMD_SET_CREATE(sub_i2c_cmds,
SHELL_CMD(scan, &dsub_device_name,
"Scan I2C devices", cmd_i2c_scan),
SHELL_CMD(recover, &dsub_device_name,
"Recover I2C bus", cmd_i2c_recover),
SHELL_CMD_ARG(scan, &dsub_device_name,
"Scan I2C devices",
cmd_i2c_scan, 2, 0),
SHELL_CMD_ARG(recover, &dsub_device_name,
"Recover I2C bus",
cmd_i2c_recover, 2, 0),
SHELL_CMD_ARG(read, &dsub_device_name,
"Read bytes from an I2C device",
cmd_i2c_read, 3, MAX_I2C_BYTES),
cmd_i2c_read, 4, MAX_I2C_BYTES),
SHELL_CMD_ARG(read_byte, &dsub_device_name,
"Read a byte from an I2C device",
cmd_i2c_read_byte, 3, 1),
cmd_i2c_read_byte, 4, 1),
SHELL_CMD_ARG(write, &dsub_device_name,
"Write bytes to an I2C device",
cmd_i2c_write, 3, MAX_I2C_BYTES),
cmd_i2c_write, 4, MAX_I2C_BYTES),
SHELL_CMD_ARG(write_byte, &dsub_device_name,
"Write a byte to an I2C device",
cmd_i2c_write_byte, 4, 1),
cmd_i2c_write_byte, 5, 0),
SHELL_SUBCMD_SET_END /* Array terminated. */
);