michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: Perform a runtime check if a driver is capable of an operation

Browse source 
Driver APIs might not implement all operations, making it possible for
a user thread to get the kernel to execute a function at 0x00000000.

Perform runtime checks in all the driver handlers, checking if they're
capable of performing the requested operation.

Fixes #6907.

Signed-off-by: Leandro Pereira <leandro.pereira@intel.com>
This commit is contained in:
Leandro Pereira 2018-04-04 13:50:32 -07:00 • committed by Anas Nashif
commit c200367b68
20 changed files with 224 additions and 119 deletions
Download patch file Download diff file Expand all files Collapse all files

17
drivers/flash/flash_handlers.c
View file

@ -9,7 +9,7 @@
_SYSCALL_HANDLER(flash_read, dev, offset, data, len)
{
_SYSCALL_OBJ(dev, K_OBJ_DRIVER_FLASH);
_SYSCALL_DRIVER_FLASH(dev, read);
_SYSCALL_MEMORY_WRITE(data, len);
return _impl_flash_read((struct device *)dev, offset, (void *)data,
len);
@ -17,7 +17,7 @@ _SYSCALL_HANDLER(flash_read, dev, offset, data, len)
_SYSCALL_HANDLER(flash_write, dev, offset, data, len)
{
_SYSCALL_OBJ(dev, K_OBJ_DRIVER_FLASH);
_SYSCALL_DRIVER_FLASH(dev, write);
_SYSCALL_MEMORY_READ(data, len);
return _impl_flash_write((struct device *)dev, offset,
(const void *)data, len);
@ -25,7 +25,7 @@ _SYSCALL_HANDLER(flash_write, dev, offset, data, len)
_SYSCALL_HANDLER(flash_write_protection_set, dev, enable)
{
_SYSCALL_OBJ(dev, K_OBJ_DRIVER_FLASH);
_SYSCALL_DRIVER_FLASH(dev, write_protection);
return _impl_flash_write_protection_set((struct device *)dev, enable);
}
@ -35,7 +35,7 @@ _SYSCALL_HANDLER1_SIMPLE(flash_get_write_block_size, K_OBJ_DRIVER_FLASH,
#ifdef CONFIG_FLASH_PAGE_LAYOUT
_SYSCALL_HANDLER(flash_get_page_info_by_offs, dev, offs, info)
{
_SYSCALL_OBJ(dev, K_OBJ_DRIVER_FLASH);
_SYSCALL_DRIVER_FLASH(dev, page_layout);
_SYSCALL_MEMORY_WRITE(info, sizeof(struct flash_pages_info));
return _impl_flash_get_page_info_by_offs((struct device *)dev, offs,
(struct flash_pages_info *)info);
@ -43,12 +43,15 @@ _SYSCALL_HANDLER(flash_get_page_info_by_offs, dev, offs, info)
_SYSCALL_HANDLER(flash_get_page_info_by_idx, dev, idx, info)
{
_SYSCALL_OBJ(dev, K_OBJ_DRIVER_FLASH);
_SYSCALL_DRIVER_FLASH(dev, page_layout);
_SYSCALL_MEMORY_WRITE(info, sizeof(struct flash_pages_info));
return _impl_flash_get_page_info_by_idx((struct device *)dev, idx,
(struct flash_pages_info *)info);
}
_SYSCALL_HANDLER1_SIMPLE(flash_get_page_count, K_OBJ_DRIVER_FLASH,
struct device *);
_SYSCALL_HANDLER(flash_get_page_count, dev)
{
_SYSCALL_DRIVER_FLASH(dev, page_layout);
return _impl_flash_get_page_count((struct device *)dev);
}
#endif