scripts: set_assignees.py: Use "size: XS" label for one-liners
Previously, one-line changes were tagged as "Trivial". The description of the "Trivial" label states: "Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.". Just because a change only affects a single line of code, it does not mean that it is a trivial change. It may have difficult to understand implications which require approval of the responsible maintainer. For this reason, change the label to "size: XS" and let humans judge if a PR is trivial or not. Signed-off-by: Martin Jäger <martin@libre.solar>
This commit is contained in:
parent
5df1df2e7a
commit
c1a3bfb5f4
1 changed files with 2 additions and 5 deletions
|
@ -70,15 +70,12 @@ def process_pr(gh, maintainer_file, number):
|
|||
all_areas = set()
|
||||
fn = list(pr.get_files())
|
||||
|
||||
manifest_change = False
|
||||
for changed_file in fn:
|
||||
if changed_file.filename in ['west.yml','submanifests/optional.yaml']:
|
||||
manifest_change = True
|
||||
break
|
||||
|
||||
# one liner PRs should be trivial
|
||||
if pr.commits == 1 and (pr.additions <= 1 and pr.deletions <= 1) and not manifest_change:
|
||||
labels = {'Trivial'}
|
||||
if pr.commits == 1 and (pr.additions <= 1 and pr.deletions <= 1):
|
||||
labels = {'size: XS'}
|
||||
|
||||
if len(fn) > 500:
|
||||
log(f"Too many files changed ({len(fn)}), skipping....")
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue