michaelh/zephyr
1
0
Fork 0
Code Releases Activity

net: conn_mgr: Create conn_mgr thread dynamically

Browse source 
Statically created threads with K_THREAD_DEFINE() are launched only
after the SYS_INIT phase. This does not play well with NET_CONFIG
library, which may block during SYS_INIT until network interface
is UP and RUNNING.

In order to be able to connect to L2 network and thus mark the
network interface as running and unblock NET_CONFIG, we need to be
able to run conn_mgr thread during SYS_INIT. This can be achieved,
by starting the thread dynamically during SYS_INIT phase, instead
of relying on static thread creation.

Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
This commit is contained in:
Robert Lubos 2023-07-11 14:05:28 +02:00 • committed by Carles Cufí
commit c15e3d448c
1 changed files with 8 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

14
subsys/net/conn_mgr/conn_mgr.c
View file

@ -23,6 +23,10 @@ LOG_MODULE_REGISTER(conn_mgr, CONFIG_NET_CONNECTION_MANAGER_LOG_LEVEL);
#define THREAD_PRIORITY K_PRIO_PREEMPT(7)
#endif
static K_THREAD_STACK_DEFINE(conn_mgr_thread_stack,
CONFIG_NET_CONNECTION_MANAGER_STACK_SIZE);
static struct k_thread conn_mgr_thread;
/* Internal state array tracking readiness, flags, and other state information for all available
* ifaces. Note that indexing starts at 0, whereas Zephyr iface indices start at 1.
* conn_mgr_get_if_by_index and conn_mgr_get_index_for_if are used to go back and forth between
@ -212,10 +216,6 @@ static void conn_mgr_handler(void)
}
}
K_THREAD_DEFINE(conn_mgr, CONFIG_NET_CONNECTION_MANAGER_STACK_SIZE,
(k_thread_entry_t)conn_mgr_handler, NULL, NULL, NULL,
THREAD_PRIORITY, 0, 0);
void conn_mgr_resend_status(void)
{
k_mutex_lock(&conn_mgr_lock, K_FOREVER);
@ -326,12 +326,14 @@ static int conn_mgr_init(void)
{
int i;
for (i = 0; i < ARRAY_SIZE(iface_states); i++) {
iface_states[i] = 0;
}
k_thread_start(conn_mgr);
k_thread_create(&conn_mgr_thread, conn_mgr_thread_stack,
CONFIG_NET_CONNECTION_MANAGER_STACK_SIZE,
(k_thread_entry_t)conn_mgr_handler,
NULL, NULL, NULL, THREAD_PRIORITY, 0, K_NO_WAIT);
return 0;
}