michaelh/zephyr
1
0
Fork 0
Code Releases Activity

net: pkt: Have separate create time for net_pkt

Browse source 
This value is used to measure the RX/TX statistics. The previous
use of the timestamp field did not work in RX path as the timestamp
value could be overwritten by the driver if gPTP timestamping
is enabled. So to fix the RX statistics, use a separate field
for the create time.

Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
This commit is contained in:
Jukka Rissanen 2021-04-13 13:04:42 +03:00 • committed by Jukka Rissanen
commit bd03493fdc
4 changed files with 39 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

12
subsys/net/ip/net_if.c
View file

@ -210,11 +210,9 @@ static bool net_if_tx(struct net_if *iface, struct net_pkt *pkt)
};
struct net_linkaddr_storage ll_dst_storage;
struct net_context *context;
uint32_t create_time;
int status;
/* Timestamp of the current network packet sent if enabled */
struct net_ptp_time start_timestamp;
/* We collect send statistics for each socket priority if enabled */
uint8_t pkt_priority;
@ -222,6 +220,8 @@ static bool net_if_tx(struct net_if *iface, struct net_pkt *pkt)
return false;
}
create_time = net_pkt_create_time(pkt);
debug_check_packet(pkt);
/* If there're any link callbacks, with such a callback receiving
@ -247,8 +247,6 @@ static bool net_if_tx(struct net_if *iface, struct net_pkt *pkt)
}
if (IS_ENABLED(CONFIG_NET_PKT_TXTIME_STATS)) {
memcpy(&start_timestamp, net_pkt_timestamp(pkt),
sizeof(start_timestamp));
pkt_priority = net_pkt_priority(pkt);
if (IS_ENABLED(CONFIG_NET_PKT_TXTIME_STATS_DETAIL)) {
@ -268,13 +266,13 @@ static bool net_if_tx(struct net_if *iface, struct net_pkt *pkt)
net_stats_update_tc_tx_time(iface,
pkt_priority,
start_timestamp.nanosecond,
create_time,
end_tick);
if (IS_ENABLED(CONFIG_NET_PKT_TXTIME_STATS_DETAIL)) {
update_txtime_stats_detail(
pkt,
start_timestamp.nanosecond,
create_time,
end_tick);
net_stats_update_tc_tx_time_detail(