michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: led: ht16k33: reorder pin interrupt configuration

Browse source 
Replace the enable callback API with the enable interrupt API, and do
it after the callback is installed.

Signed-off-by: Peter Bigot <peter.bigot@nordicsemi.no>
This commit is contained in:
Peter Bigot 2020-01-29 08:48:55 -06:00 • committed by Carles Cufí
commit bcf4d1249e
1 changed files with 4 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

14
drivers/led/ht16k33.c
View file

@ -397,14 +397,6 @@ static int ht16k33_init(struct device *dev)
return -EINVAL;
}
err = gpio_pin_interrupt_configure(irq_dev, config->irq_pin,
GPIO_INT_EDGE_FALLING);
if (err) {
LOG_ERR("Failed to configure IRQ pin flags (err %d)",
err);
return -EINVAL;
}
gpio_init_callback(&data->irq_cb, &ht16k33_irq_callback,
BIT(config->irq_pin));
@ -429,9 +421,11 @@ static int ht16k33_init(struct device *dev)
return -EIO;
}
err = gpio_pin_enable_callback(irq_dev, config->irq_pin);
err = gpio_pin_interrupt_configure(irq_dev, config->irq_pin,
GPIO_INT_EDGE_FALLING);
if (err) {
LOG_ERR("Failed to enable IRQ callback (err %d)", err);
LOG_ERR("Failed to configure IRQ pin flags (err %d)",
err);
return -EINVAL;
}
} else {