michaelh/zephyr
1
0
Fork 0
Code Releases Activity

Bluetooth: Audio: Shell: Fix use of IN_RANGE when MIN is 0

Browse source 
If the minimal value of an IN_RANGE is 0, then it is
a useless check, and the cases have been modified to
not use IN_RANGE. This also fixes some coverity issues.

Signed-off-by: Emil Gydesen <emil.gydesen@nordicsemi.no>
This commit is contained in:
Emil Gydesen 2023-06-02 16:56:49 +02:00 • committed by Anas Nashif
commit ba7fde1bae
2 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
subsys/bluetooth/audio/shell/bap_broadcast_assistant.c
View file

@ -453,7 +453,7 @@ static int cmd_bap_broadcast_assistant_add_src(const struct shell *sh,
return -ENOEXEC;
}
if (!IN_RANGE(bis_sync, 0, UINT32_MAX)) {
if (bis_sync > UINT32_MAX) {
shell_error(sh, "Invalid bis_sync: %lu", bis_sync);
return -ENOEXEC;
@ -630,7 +630,7 @@ static int cmd_bap_broadcast_assistant_add_broadcast_id(const struct shell *sh,
shell_error(sh, "failed to parse bis_sync: %d", err);
return -ENOEXEC;
} else if (!IN_RANGE(bis_sync, 0, UINT32_MAX)) {
} else if (bis_sync > UINT32_MAX) {
shell_error(sh, "Invalid bis_sync: %lu", bis_sync);
return -ENOEXEC;
@ -727,7 +727,7 @@ static int cmd_bap_broadcast_assistant_mod_src(const struct shell *sh,
return -ENOEXEC;
}
if (!IN_RANGE(bis_sync, 0, UINT32_MAX)) {
if (bis_sync > UINT32_MAX) {
shell_error(sh, "Invalid bis_sync: %lu", bis_sync);
return -ENOEXEC;