From b99b66fba2a39a096c6479692efb4d3eeb4a4609 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marin=20Jurjevi=C4=87?= Date: Wed, 9 Nov 2022 13:24:43 +0100 Subject: [PATCH] drivers: modem: gsm: fix RSSI check condition MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fixes invalid condition introduced in #48533 when FSM implementation was added. Signed-off-by: Marin Jurjević --- drivers/modem/gsm_ppp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/modem/gsm_ppp.c b/drivers/modem/gsm_ppp.c index fa91e0f77f2..76f395b5100 100644 --- a/drivers/modem/gsm_ppp.c +++ b/drivers/modem/gsm_ppp.c @@ -826,7 +826,7 @@ attaching: /* Read connection quality (RSSI) before PPP carrier is ON */ query_rssi_nolock(gsm); - if (!((gsm->minfo.mdm_rssi > 0) && (gsm->minfo.mdm_rssi != GSM_RSSI_INVALID) && + if (!((gsm->minfo.mdm_rssi) && (gsm->minfo.mdm_rssi != GSM_RSSI_INVALID) && (gsm->minfo.mdm_rssi < GSM_RSSI_MAXVAL))) { LOG_DBG("Not valid RSSI, %s", "retrying...");