michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: regulator: drop mode specific APIs

Browse source 
- Mode specific APIs repeat the same functionality offered by non-mode
  specific APIs
- The same functionality can be achieved by the non-mode APIs, since
  they apply to the active mode which can be set using
  regulator_set_mode() first.

Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
This commit is contained in:
Gerard Marull-Paretas 2022-12-01 13:14:03 +01:00 • committed by Carles Cufí
commit b909d0e560
3 changed files with 0 additions and 261 deletions
Download patch file Download diff file Expand all files Collapse all files

83
drivers/regulator/regulator_shell.c
View file

@ -128,79 +128,6 @@ static int cmd_set_mode(const struct shell *sh, size_t argc, char **argv)
return ret;
}
static int cmd_set_mode_vol(const struct shell *sh, size_t argc, char **argv)
{
int mode, lvol, uvol, ret;
const struct device *reg_dev;
reg_dev = device_get_binding(argv[1]);
if (reg_dev == NULL) {
shell_error(sh, "regulator device %s not available", argv[1]);
return -ENODEV;
}
mode = strtol(argv[2], NULL, 10);
lvol = strtol(argv[3], NULL, 10) * 1000;
uvol = strtol(argv[4], NULL, 10) * 1000;
ret = regulator_set_mode_voltage(reg_dev, mode, lvol, uvol);
if (ret < 0) {
shell_error(sh, "failed to set mode voltage, error %d", ret);
return ret;
}
ret = regulator_get_mode_voltage(reg_dev, mode);
if (ret < 0) {
shell_error(sh, "failed to get mode voltage, error %d", ret);
return ret;
}
shell_print(sh, "set voltage for mode %d to %d uV", mode, ret);
return ret;
}
static int cmd_reg_mode_en(const struct shell *sh, size_t argc, char **argv)
{
const struct device *reg_dev;
int ret, mode;
reg_dev = device_get_binding(argv[1]);
if (reg_dev == NULL) {
shell_error(sh, "regulator device %s not available", argv[1]);
return -ENODEV;
}
mode = strtol(argv[2], NULL, 10);
ret = regulator_mode_enable(reg_dev, mode);
if (ret < 0) {
shell_error(sh, "failed to enable regulator for "
"mode %d, error %d", mode, ret);
return ret;
}
shell_print(sh, "enabled regulator for mode %d", mode);
return 0;
}
static int cmd_reg_mode_dis(const struct shell *sh, size_t argc, char **argv)
{
const struct device *reg_dev;
int ret, mode;
reg_dev = device_get_binding(argv[1]);
if (reg_dev == NULL) {
shell_error(sh, "regulator device %s not available", argv[1]);
return -ENODEV;
}
mode = strtol(argv[2], NULL, 10);
ret = regulator_mode_disable(reg_dev, mode);
if (ret < 0) {
shell_error(sh, "failed to disable regulator for "
"mode %d, error %d", mode, ret);
return ret;
}
shell_print(sh, "disabled regulator for mode %d", mode);
return 0;
}
SHELL_STATIC_SUBCMD_SET_CREATE(regulator_set,
SHELL_CMD_ARG(enable, NULL,
"Enable regulator\n"
@ -217,16 +144,6 @@ SHELL_STATIC_SUBCMD_SET_CREATE(regulator_set,
SHELL_CMD_ARG(set_mode, NULL, "Set mode of regulator\n"
"Usage: set_mode <device> <mode index>",
cmd_set_mode, 3, 0),
SHELL_CMD_ARG(set_mode_vol, NULL, "Set voltage for mode of regulator\n"
"Usage: set_mode_vol <device> <mode index> "
"<low limit (uV)> <high limit (uV)>",
cmd_set_mode_vol, 5, 0),
SHELL_CMD_ARG(mode_enable, NULL,
"Enable regulator in given mode\n"
"Usage: enable <device> <mode index>", cmd_reg_mode_en, 3, 0),
SHELL_CMD_ARG(mode_disable, NULL,
"Disable regulator in given mode\n"
"Usage: disable <device> <mode index>", cmd_reg_mode_dis, 3, 0),
SHELL_SUBCMD_SET_END
);