michaelh/zephyr
1
0
Fork 0
Code Releases Activity

util: Add GENMASK helper macro definition

Browse source 
Macro is used to create contiguous bitmask between the
arguments passed to the macro.

BITS_PER_LONG is computed as the multiplication of predefined
macros `__CHAR_BIT__` and `__SIZEOF_LONG__`.

Both gcc and clang support these predefined macros.

With this change, replace the redundant defintions of
GENMASK with the new generic macro available.

Fixes #10843

Suggested-by: Ulf Magnusson <Ulf.Magnusson@nordicsemi.no>
Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
This commit is contained in:
Himanshu Jha 2018-10-30 23:15:51 +05:30 • committed by Carles Cufí
commit b8c19d8c75
3 changed files with 13 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

4
drivers/dma/dma_stm32f4x.c
View file

@ -13,6 +13,7 @@
#include <init.h>
#include <stdio.h>
#include <string.h>
#include <misc/util.h>
#define LOG_LEVEL CONFIG_DMA_LOG_LEVEL
#include <logging/log.h>
@ -88,9 +89,6 @@ struct dma_stm32_config {
/* Maximum data sent in single transfer (Bytes) */
#define DMA_STM32_MAX_DATA_ITEMS 0xffff
#define BITS_PER_LONG 32
#define GENMASK(h, l) (((~0UL) << (l)) & (~0UL >> (BITS_PER_LONG - 1 - (h))))
#define DMA_STM32_1_BASE 0x40026000
#define DMA_STM32_2_BASE 0x40026400

3
drivers/sensor/adxl372/adxl372.h
View file

@ -12,8 +12,7 @@
#include <gpio.h>
#include <spi.h>
#include <i2c.h>
#define GENMASK(h, l) (((~0UL) - (1UL << (l)) + 1) & (~0UL >> (31 - (h))))
#include <misc/util.h>
/*
* ADXL372 registers definition

11
include/misc/util.h
View file

@ -27,6 +27,17 @@
#define POINTER_TO_INT(x) ((s32_t) (x))
#define INT_TO_POINTER(x) ((void *) (x))
#if !(defined (__CHAR_BIT__) && defined (__SIZEOF_LONG__))
# error Missing required predefined macros for BITS_PER_LONG calculation
#endif
#define BITS_PER_LONG (__CHAR_BIT__ * __SIZEOF_LONG__)
/* Create a contiguous bitmask starting at bit position @l and ending at
* position @h.
*/
#define GENMASK(h, l) \
(((~0UL) - (1UL << (l)) + 1) & (~0UL >> (BITS_PER_LONG - 1 - (h))))
/* Evaluates to 0 if cond is true-ish; compile error otherwise */
#define ZERO_OR_COMPILE_ERROR(cond) ((int) sizeof(char[1 - 2 * !(cond)]) - 1)