michaelh/zephyr
1
0
Fork 0
Code Releases Activity

driver: host_sub: npcx: remove self-assignment for clearing status.

Browse source 
This CL removes self-assignment of SMC_STS register for clearing its
status.

Fixes #33089.

Signed-off-by: Mulin Chao <mlchao@nuvoton.com>
This commit is contained in:
Mulin Chao 2021-03-08 21:44:43 -08:00 • committed by Anas Nashif
commit b6ad85cdd9
1 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
drivers/espi/host_subs_npcx.c
View file

@ -972,6 +972,7 @@ int npcx_host_init_subs_core_domain(const struct device *host_bus_dev,
const struct device *const clk_dev = const struct device *const clk_dev =
device_get_binding(NPCX_CLK_CTRL_NAME); device_get_binding(NPCX_CLK_CTRL_NAME);
int i; int i;
uint8_t shm_sts;
host_sub_data.callbacks = callbacks; host_sub_data.callbacks = callbacks;
host_sub_data.host_bus_dev = host_bus_dev; host_sub_data.host_bus_dev = host_bus_dev;
@ -998,7 +999,8 @@ int npcx_host_init_subs_core_domain(const struct device *host_bus_dev,
*/ */
inst_shm->SMC_CTL &= BIT(NPCX_SMC_CTL_HOSTWAIT); inst_shm->SMC_CTL &= BIT(NPCX_SMC_CTL_HOSTWAIT);
/* Clear shared memory status */ /* Clear shared memory status */
inst_shm->SMC_STS = inst_shm->SMC_STS; shm_sts = inst_shm->SMC_STS;
inst_shm->SMC_STS = shm_sts;
/* host sub-module initialization in core domain */ /* host sub-module initialization in core domain */
#if defined(CONFIG_ESPI_PERIPHERAL_8042_KBC) #if defined(CONFIG_ESPI_PERIPHERAL_8042_KBC)