From b4fb5300da46939dc5dd92832d85da12bb5d0177 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andrzej=20G=C5=82=C4=85bek?= Date: Thu, 12 Jan 2023 13:46:37 +0100 Subject: [PATCH] boards: nrf52840dk_nrf52840: Do not enable arduino_serial by default MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This is a follow-up to commit 25d7a09aa5e3b1826c1571872204852815df3ad0. The arduino_serial/uart1 node should not be enabled by default because even if an application does not use it, the default CONFIG_SERIAL=y setting causes that it is anyway initialized, so the UARTE peripheral acquires its assigned pins (and they cannot be used in other way) and its enabled receiver causes increased current consumption (by ~500 uA) when the CPU is sleeping. This affects e.g. the boards/nrf/system_off sample. Applications that actually need to use this UART or shields that use the arduino_serial node should enable the node explicitly. Keep this node disabled by default for the nrf52840dk_nrf52840 board and also for boards whose definitions are mostly copies of the above: nrf52833dk_nrf52833 and nrf21540dk_nrf52840. Update also accordingly a few overlay files in tests/ that were disabling this node because of the pins it undesirably acquired. Signed-off-by: Andrzej Głąbek --- boards/arm/nrf21540dk_nrf52840/nrf21540dk_nrf52840.dts | 1 - boards/arm/nrf52833dk_nrf52833/nrf52833dk_nrf52833.dts | 1 - boards/arm/nrf52840dk_nrf52840/nrf52840dk_nrf52840.dts | 1 - .../gpio/gpio_basic_api/boards/nrf52840dk_nrf52840.overlay | 4 ---- tests/drivers/i2s/i2s_api/boards/nrf52840dk_nrf52840.overlay | 4 ---- .../drivers/i2s/i2s_speed/boards/nrf52840dk_nrf52840.overlay | 4 ---- .../regulator/fixed/boards/nrf52840dk_nrf52840.overlay | 5 ----- 7 files changed, 20 deletions(-) diff --git a/boards/arm/nrf21540dk_nrf52840/nrf21540dk_nrf52840.dts b/boards/arm/nrf21540dk_nrf52840/nrf21540dk_nrf52840.dts index e89f1242d52..80d6ea3a8f4 100644 --- a/boards/arm/nrf21540dk_nrf52840/nrf21540dk_nrf52840.dts +++ b/boards/arm/nrf21540dk_nrf52840/nrf21540dk_nrf52840.dts @@ -167,7 +167,6 @@ }; arduino_serial: &uart1 { - status = "okay"; current-speed = <115200>; pinctrl-0 = <&uart1_default>; pinctrl-1 = <&uart1_sleep>; diff --git a/boards/arm/nrf52833dk_nrf52833/nrf52833dk_nrf52833.dts b/boards/arm/nrf52833dk_nrf52833/nrf52833dk_nrf52833.dts index cd8668d2d89..ad7f9dfa57b 100644 --- a/boards/arm/nrf52833dk_nrf52833/nrf52833dk_nrf52833.dts +++ b/boards/arm/nrf52833dk_nrf52833/nrf52833dk_nrf52833.dts @@ -144,7 +144,6 @@ }; arduino_serial: &uart1 { - status = "okay"; current-speed = <115200>; pinctrl-0 = <&uart1_default>; pinctrl-1 = <&uart1_sleep>; diff --git a/boards/arm/nrf52840dk_nrf52840/nrf52840dk_nrf52840.dts b/boards/arm/nrf52840dk_nrf52840/nrf52840dk_nrf52840.dts index b87e88a1ec1..bc87fa7077d 100644 --- a/boards/arm/nrf52840dk_nrf52840/nrf52840dk_nrf52840.dts +++ b/boards/arm/nrf52840dk_nrf52840/nrf52840dk_nrf52840.dts @@ -156,7 +156,6 @@ }; arduino_serial: &uart1 { - status = "okay"; current-speed = <115200>; pinctrl-0 = <&uart1_default>; pinctrl-1 = <&uart1_sleep>; diff --git a/tests/drivers/gpio/gpio_basic_api/boards/nrf52840dk_nrf52840.overlay b/tests/drivers/gpio/gpio_basic_api/boards/nrf52840dk_nrf52840.overlay index 86a4321d80a..db751c4c329 100644 --- a/tests/drivers/gpio/gpio_basic_api/boards/nrf52840dk_nrf52840.overlay +++ b/tests/drivers/gpio/gpio_basic_api/boards/nrf52840dk_nrf52840.overlay @@ -11,7 +11,3 @@ in-gpios = <&gpio1 2 0>; /* Arduino D1 */ }; }; - -&uart1 { - status = "disabled"; -}; diff --git a/tests/drivers/i2s/i2s_api/boards/nrf52840dk_nrf52840.overlay b/tests/drivers/i2s/i2s_api/boards/nrf52840dk_nrf52840.overlay index 1a954d765a7..eaac2f818ae 100644 --- a/tests/drivers/i2s/i2s_api/boards/nrf52840dk_nrf52840.overlay +++ b/tests/drivers/i2s/i2s_api/boards/nrf52840dk_nrf52840.overlay @@ -9,10 +9,6 @@ }; }; -&uart1 { - status = "disabled"; -}; - &i2s0 { status = "okay"; pinctrl-0 = <&i2s0_default_alt>; diff --git a/tests/drivers/i2s/i2s_speed/boards/nrf52840dk_nrf52840.overlay b/tests/drivers/i2s/i2s_speed/boards/nrf52840dk_nrf52840.overlay index bbc26f2e1ea..af235d9e21e 100644 --- a/tests/drivers/i2s/i2s_speed/boards/nrf52840dk_nrf52840.overlay +++ b/tests/drivers/i2s/i2s_speed/boards/nrf52840dk_nrf52840.overlay @@ -17,10 +17,6 @@ }; }; -&uart1 { - status = "disabled"; -}; - &i2s0 { status = "okay"; pinctrl-0 = <&i2s0_default_alt>; diff --git a/tests/drivers/regulator/fixed/boards/nrf52840dk_nrf52840.overlay b/tests/drivers/regulator/fixed/boards/nrf52840dk_nrf52840.overlay index 2f22134e46f..06727c99807 100644 --- a/tests/drivers/regulator/fixed/boards/nrf52840dk_nrf52840.overlay +++ b/tests/drivers/regulator/fixed/boards/nrf52840dk_nrf52840.overlay @@ -15,8 +15,3 @@ check-gpios = <&gpio1 2 (GPIO_ACTIVE_HIGH | GPIO_PULL_DOWN)>; }; }; - -&uart1 { - /* Default-enabled Arduino UART steals the pins we want. */ - status = "disabled"; -};