michaelh/zephyr
1
0
Fork 0
Code Releases Activity

kernel: timer: Fix incorrect behavior for timers with K_FOREVER period

Browse source 
Zephyr docs state that timers will act as one-shot timers when started
with a period of K_NO_WAIT or K_FOREVER. However the code adjusting
period was setting K_FOREVER timeout ticks to 1 which caused the timer
to expire every tick. This adds a check to not adjust K_FOREVER periods

Signed-off-by: Eric Johnson <eric@liveathos.com>
This commit is contained in:
Eric Johnson 2021-03-05 08:31:50 -06:00 • committed by Anas Nashif
commit b4aeef4d5b
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
kernel/timer.c
View file

@ -126,7 +126,8 @@ void z_impl_k_timer_start(struct k_timer *timer, k_timeout_t duration,
* argument the same way k_sleep() does), but historical. The * argument the same way k_sleep() does), but historical. The
* timer_api test relies on this behavior. * timer_api test relies on this behavior.
*/ */
if (period.ticks != 0 && Z_TICK_ABS(period.ticks) < 0) { if (!K_TIMEOUT_EQ(period, K_FOREVER) && period.ticks != 0 &&
Z_TICK_ABS(period.ticks) < 0) {
period.ticks = MAX(period.ticks - 1, 1); period.ticks = MAX(period.ticks - 1, 1);
} }
if (Z_TICK_ABS(duration.ticks) < 0) { if (Z_TICK_ABS(duration.ticks) < 0) {