michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: entropy: fix native_posix driver for more than 3 byte requests

Browse source 
Fix the native_posix fake entropy driver for more than 3 byte requests,
and specially for native_sim//64 builds.

The host random() provides a number between 0 and 2**31-1 (INT_MAX),
so bit 32 was always 0.
So when filling a buffer with more than 3 bytes we would be filling
each 4th byte with a byte which always had its MSbit as 0.

For LP64 native_sim//64 builds, this was even worse, as the driver had
another bug where we assumed random() returned the whole long filled,
and therefore all 4 upper bytes would be 0.

Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
This commit is contained in:
Alberto Escolar Piedras 2024-12-30 10:26:20 +01:00 • committed by Benjamin Cabé
commit b3407f04e7
1 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
drivers/entropy/fake_entropy_native_posix.c
View file

@ -42,7 +42,10 @@ static int entropy_native_posix_get_entropy(const struct device *dev,
*/
long value = nsi_host_random();
size_t to_copy = MIN(length, sizeof(long int));
/* The host random() provides a number between 0 and 2**31-1. Bit 32 is always 0.
* So let's just use the lower 3 bytes discarding the upper 7 bits
*/
size_t to_copy = MIN(length, 3);
memcpy(buffer, &value, to_copy);
buffer += to_copy;